Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1553313002: Merge to XFA: Cover FPDFBookmark_Find() with embedder tests. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Cover FPDFBookmark_Find() with embedder tests. Original Review URL: https://codereview.chromium.org/1559043006 . (cherry picked from commit 5dac8047f02c937a5a3546a8cc5b352db2188d97) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0861c161376074bce453de31fdf96e120c482696

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
TBR, automatic
4 years, 11 months ago (2016-01-05 00:31:53 UTC) #1
Tom Sepez
TBR, automatic
4 years, 11 months ago (2016-01-05 00:32:24 UTC) #2
Tom Sepez
Committed patchset #1 (id:1) manually as 0861c161376074bce453de31fdf96e120c482696 (presubmit successful).
4 years, 11 months ago (2016-01-05 00:35:56 UTC) #4
Lei Zhang
4 years, 11 months ago (2016-01-05 00:36:31 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698