Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 1559043006: Cover FPDFBookmark_Find() with embedder tests. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Typo in comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, another entry point.
4 years, 11 months ago (2016-01-04 23:17:21 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-05 00:16:37 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-05 00:29:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5dac8047f02c937a5a3546a8cc5b352db2188d97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698