Store ninepatch chunks in the png header in CodexTest

Store ninepatch chunks in the png header in CodexTest

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.
https://googleplex-android-review.git.corp.google.com/#/c/832067/

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1553303003

Committed: https://skia.googlesource.com/skia/+/133eaaacdd23fb45db47a32e854eab3ecd76f213

[msarett, 2016-01-05 15:05:49]

Description was changed from

==========
Store ninepatch chunks in the png header

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.

BUG=skia:
==========

to

==========
Store ninepatch chunks in the png header

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-07 17:43:01]

msarett@google.com changed reviewers:
+ scroggo@google.com

[msarett, 2016-01-07 17:43:01]

https://codereview.chromium.org/1553303003/diff/1/tests/CodexTest.cpp
File tests/CodexTest.cpp (left):

https://codereview.chromium.org/1553303003/diff/1/tests/CodexTest.cpp#oldcode752
tests/CodexTest.cpp:752: #if PNG_LIBPNG_VER < 10600
While we do want Skia to work for any version of libpng, I don't have a setup
(with an old libpng) to test if/how we need to modify this code block.

I think it's best to remove it.

[scroggo, 2016-01-07 18:04:43]

lgtm

> Store ninepatch chunks in the png header

nit: in a test. This doesn't actually change any Skia behavior.

> We are making a change in Android to store ninepatch chunks in the
> png header.  Thus, our ninepatch test should match the Android
> framework's use.

Link to the CL or the code? I guess the link is only good for Googlers :-/

https://codereview.chromium.org/1553303003/diff/1/tests/CodexTest.cpp
File tests/CodexTest.cpp (left):

https://codereview.chromium.org/1553303003/diff/1/tests/CodexTest.cpp#oldcode752
tests/CodexTest.cpp:752: #if PNG_LIBPNG_VER < 10600
On 2016/01/07 17:43:01, msarett wrote:
> While we do want Skia to work for any version of libpng, I don't have a setup
> (with an old libpng) to test if/how we need to modify this code block.
> 
> I think it's best to remove it.

You don't think we should just change it to PNG_HAVE_IHDR?

[msarett, 2016-01-07 18:12:07]

Description was changed from

==========
Store ninepatch chunks in the png header

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Store ninepatch chunks in the png header in CodexTest

This is in order to match Android.

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.
https://googleplex-android-review.git.corp.google.com/#/c/832067/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-07 18:16:30]

Description was changed from

==========
Store ninepatch chunks in the png header in CodexTest

This is in order to match Android.

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.
https://googleplex-android-review.git.corp.google.com/#/c/832067/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Store ninepatch chunks in the png header in CodexTest

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.
https://googleplex-android-review.git.corp.google.com/#/c/832067/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[msarett, 2016-01-07 18:20:48]

Updated the commit message and decided to keep the #ifdef
for old libpng.

https://codereview.chromium.org/1553303003/diff/1/tests/CodexTest.cpp
File tests/CodexTest.cpp (left):

https://codereview.chromium.org/1553303003/diff/1/tests/CodexTest.cpp#oldcode752
tests/CodexTest.cpp:752: #if PNG_LIBPNG_VER < 10600
On 2016/01/07 18:04:43, scroggo wrote:
> On 2016/01/07 17:43:01, msarett wrote:
> > While we do want Skia to work for any version of libpng, I don't have a
setup
> > (with an old libpng) to test if/how we need to modify this code block.
> > 
> > I think it's best to remove it.
> 
> You don't think we should just change it to PNG_HAVE_IHDR?

Hmmm ok - I went back and forth on this anyway.  I'm not sure it will work or if
it's necessary, but it seems benign at worst.

[scroggo, 2016-01-07 18:27:08]

lgtm in patch set 2

[msarett, 2016-01-07 18:32:23]

The CQ bit was checked by msarett@google.com

[commit-bot: I haz the power, 2016-01-07 18:32:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1553303003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1553303003/20001

[commit-bot: I haz the power, 2016-01-07 19:03:31]

Description was changed from

==========
Store ninepatch chunks in the png header in CodexTest

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.
https://googleplex-android-review.git.corp.google.com/#/c/832067/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Store ninepatch chunks in the png header in CodexTest

We are making a change in Android to store ninepatch chunks in the
png header.  Thus, our ninepatch test should match the Android
framework's use.
https://googleplex-android-review.git.corp.google.com/#/c/832067/

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/133eaaacdd23fb45db47a32e854eab3ecd76f213
==========

[commit-bot: I haz the power, 2016-01-07 19:03:32]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/133eaaacdd23fb45db47a32e854eab3ecd76f213