Issue 155314: Disk cache: Don't evict entries if we are busy doing other stuff....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155314: Disk cache: Don't evict entries if we are busy doing other stuff.... (Closed)

Created:
11 years, 5 months ago by rvargas (doing something else)

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disk cache: Don't evict entries if we are busy doing other stuff. BUG=10727 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20330

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -20 lines)			Patch
M	net/disk_cache/backend_impl.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	net/disk_cache/backend_impl.cc	View	1	2 chunks	+20 lines, -7 lines	1 comment	Download
M	net/disk_cache/eviction.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/disk_cache/eviction.cc	View		8 chunks	+29 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rvargas (doing something else)

I added the extra histogram. On 2009/07/09 21:51:10, Nicolas Sylvain wrote: > LGTM

11 years, 5 months ago (2009-07-09 22:25:23 UTC) #3

Nicolas Sylvain

11 years, 5 months ago (2009-07-09 22:32:21 UTC) #4

http://codereview.chromium.org/155314/diff/9/1010
File net/disk_cache/backend_impl.cc (right):

http://codereview.chromium.org/155314/diff/9/1010#newcode881
Line 881: CACHE_UMA(COUNTS, "NumberOfReferences", 0, num_refs_);
still lgtm

Expand Messages | Collapse Messages