Chromium Code Reviews
Help | Chromium Project | Sign in
(550)

Issue 155314: Disk cache: Don't evict entries if we are busy doing other stuff.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years ago by rvargas
Modified:
4 years, 1 month ago
Reviewers:
Nicolas Sylvain
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Disk cache: Don't evict entries if we are busy doing other stuff. BUG=10727 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20330

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -20 lines) Patch
M net/disk_cache/backend_impl.h View 1 chunk +6 lines, -3 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 1 2 chunks +20 lines, -7 lines 1 comment Download
M net/disk_cache/eviction.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/disk_cache/eviction.cc View 8 chunks +29 lines, -10 lines 0 comments Download
Commit: (user is not authenticated) CQ not working?

Messages

Total messages: 4 (0 generated)
rvargas
6 years ago (2009-07-09 20:58:24 UTC) #1
Nicolas Sylvain
LGTM
6 years ago (2009-07-09 21:51:10 UTC) #2
rvargas
I added the extra histogram. On 2009/07/09 21:51:10, Nicolas Sylvain wrote: > LGTM
6 years ago (2009-07-09 22:25:23 UTC) #3
Nicolas Sylvain
6 years ago (2009-07-09 22:32:21 UTC) #4
http://codereview.chromium.org/155314/diff/9/1010
File net/disk_cache/backend_impl.cc (right):

http://codereview.chromium.org/155314/diff/9/1010#newcode881
Line 881: CACHE_UMA(COUNTS, "NumberOfReferences", 0, num_refs_);
still lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 3ea459f