Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1552763002: Global conversion of Pass()→std::move(): Linux GN static library edition (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
avayvod+watch_chromium.org, chromium-reviews, devtools-reviews_chromium.org, feature-media-reviews_chromium.org, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jasonroberts+watch_google.com, miu+watch_chromium.org, pfeldman, xjz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Global conversion of Pass()→std::move(): Linux GN static library edition 😵 There's so many different build configs... BUG=557422 R=avi@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/34e0e082ff62320a32a56d8b4e61eca1101bb9a5 Cr-Commit-Position: refs/heads/master@{#367158}

Patch Set 1 #

Patch Set 2 : Manual remove one more pessimizing move #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -33 lines) Patch
M components/devtools_service/devtools_agent_host.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/devtools_service/devtools_http_server.cc View 12 chunks +23 lines, -22 lines 0 comments Download
M components/devtools_service/devtools_registry_impl.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M components/devtools_service/devtools_service.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/devtools_service/devtools_service_delegate.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M device/devices_app/devices_apptest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/cast/receiver/frame_receiver_unittest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
dcheng
+avi for general review / sanity check +jam for OWNERS stamp Hopefully really the last ...
4 years, 11 months ago (2015-12-30 08:23:55 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552763002/1
4 years, 11 months ago (2015-12-30 08:24:14 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/159686)
4 years, 11 months ago (2015-12-30 08:29:39 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552763002/20001
4 years, 11 months ago (2015-12-30 08:41:39 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 09:05:49 UTC) #16
Avi (use Gerrit)
lgtm
4 years, 11 months ago (2015-12-30 16:36:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552763002/20001
4 years, 11 months ago (2015-12-30 17:06:34 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2015-12-30 17:11:36 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 17:12:44 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34e0e082ff62320a32a56d8b4e61eca1101bb9a5
Cr-Commit-Position: refs/heads/master@{#367158}

Powered by Google App Engine
This is Rietveld 408576698