components/devtools_service/devtools_service.cc - Issue 1552763002: Global conversion of Pass()→std::move(): Linux GN static library edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/devtools_service/devtools_service.cc

Issue 1552763002: Global conversion of Pass()→std::move(): Linux GN static library edition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Manual remove one more pessimizing move Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/devtools_service/devtools_registry_impl.cc ('k') | components/devtools_service/devtools_service_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/devtools_service/devtools_service.cc

diff --git a/components/devtools_service/devtools_service.cc b/components/devtools_service/devtools_service.cc

index 36a8309465ca44093bf8599f4445fa0f169b9021..f2b4704600c2c14ee581826de90009ca91f94c00 100644

--- a/components/devtools_service/devtools_service.cc

+++ b/components/devtools_service/devtools_service.cc

@@ -4,6 +4,8 @@

#include "components/devtools_service/devtools_service.h"

+#include <utility>

#include "base/logging.h"

#include "components/devtools_service/devtools_http_server.h"

#include "mojo/application/public/cpp/application_impl.h"

@@ -20,7 +22,7 @@ DevToolsService::~DevToolsService() {

void DevToolsService::BindToCoordinatorRequest(

mojo::InterfaceRequest<DevToolsCoordinator> request) {

- coordinator_bindings_.AddBinding(this, request.Pass());

+ coordinator_bindings_.AddBinding(this, std::move(request));

}

void DevToolsService::Initialize(uint16_t remote_debugging_port) {

« no previous file with comments | « components/devtools_service/devtools_registry_impl.cc ('k') | components/devtools_service/devtools_service_delegate.cc » ('j') | no next file with comments »