Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1552723002: Convert Pass()→std::move() in //android_webview (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
boliu
CC:
android-webview-reviews_chromium.org, cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //android_webview (╯^□^)╯︵ ❄☃❄ BUG=557422 R=boliu@chromium.org Committed: https://crrev.com/2c86c0a1752156d1d921aa1fc7b922700185e625 Cr-Commit-Position: refs/heads/master@{#367119}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -127 lines) Patch
M android_webview/browser/aw_browser_context.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M android_webview/browser/aw_browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M android_webview/browser/aw_pref_store.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/browser/child_frame.cc View 2 chunks +3 lines, -1 line 0 comments Download
M android_webview/browser/hardware_renderer.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc View 11 chunks +19 lines, -18 lines 0 comments Download
M android_webview/browser/net/aw_request_interceptor.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 6 chunks +15 lines, -16 lines 0 comments Download
M android_webview/browser/net/aw_url_request_job_factory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M android_webview/browser/shared_renderer_state.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M android_webview/browser/test/rendering_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M android_webview/native/android_protocol_handler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M android_webview/native/aw_contents.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M android_webview/native/aw_contents_io_thread_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_dev_tools_server.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/cookie_manager.cc View 7 chunks +9 lines, -6 lines 0 comments Download
M android_webview/native/permission/aw_permission_request.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M android_webview/native/permission/media_access_permission_request.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M android_webview/native/permission/media_access_permission_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/permission/permission_request_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M android_webview/native/permission/permission_request_handler_unittest.cc View 12 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dcheng
4 years, 11 months ago (2015-12-29 23:38:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552723002/1
4 years, 11 months ago (2015-12-29 23:43:41 UTC) #4
boliu
lgtm!
4 years, 11 months ago (2015-12-30 00:03:45 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 00:10:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552723002/1
4 years, 11 months ago (2015-12-30 00:12:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 00:18:22 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 00:19:19 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2c86c0a1752156d1d921aa1fc7b922700185e625
Cr-Commit-Position: refs/heads/master@{#367119}

Powered by Google App Engine
This is Rietveld 408576698