Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3036)

Unified Diff: android_webview/native/permission/aw_permission_request.cc

Issue 1552723002: Convert Pass()→std::move() in //android_webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/permission/aw_permission_request.cc
diff --git a/android_webview/native/permission/aw_permission_request.cc b/android_webview/native/permission/aw_permission_request.cc
index 1eb5401b22ddc76e4e7015957139619ef8656651..0e661831a27b886888bf733751e8ea8aea9c47bf 100644
--- a/android_webview/native/permission/aw_permission_request.cc
+++ b/android_webview/native/permission/aw_permission_request.cc
@@ -4,6 +4,8 @@
#include "android_webview/native/permission/aw_permission_request.h"
+#include <utility>
+
#include "android_webview/native/permission/aw_permission_request_delegate.h"
#include "base/android/jni_string.h"
#include "jni/AwPermissionRequest_jni.h"
@@ -20,7 +22,7 @@ base::android::ScopedJavaLocalRef<jobject> AwPermissionRequest::Create(
base::WeakPtr<AwPermissionRequest>* weak_ptr) {
base::android::ScopedJavaLocalRef<jobject> java_peer;
AwPermissionRequest* permission_request =
- new AwPermissionRequest(delegate.Pass(), &java_peer);
+ new AwPermissionRequest(std::move(delegate), &java_peer);
*weak_ptr = permission_request->weak_factory_.GetWeakPtr();
return java_peer;
}
@@ -28,9 +30,7 @@ base::android::ScopedJavaLocalRef<jobject> AwPermissionRequest::Create(
AwPermissionRequest::AwPermissionRequest(
scoped_ptr<AwPermissionRequestDelegate> delegate,
ScopedJavaLocalRef<jobject>* java_peer)
- : delegate_(delegate.Pass()),
- processed_(false),
- weak_factory_(this) {
+ : delegate_(std::move(delegate)), processed_(false), weak_factory_(this) {
DCHECK(delegate_.get());
DCHECK(java_peer);
« no previous file with comments | « android_webview/native/cookie_manager.cc ('k') | android_webview/native/permission/media_access_permission_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698