Internals: throw an exception when page height or width is 0.

Internals: throw an exception when page height or width is 0.

The two methods pageNumber() and numberOfPages() on the window.internals object
allowed 0 as page height, which results in a division by zero in multicol (and
general failure to paginate in other parts of the code). Have the methods raise
an exception when such values are provided. Also specify the default width and
height values in Internals.idl rather than in Internals.h, so that they
actually do something. Our default page width and height were effectively 0 for
these methods.

Assert that width and height have valid values (i.e. greater than 0) in
PrintContext::begin().

BUG=571348
R=rune@opera.com

Committed: https://crrev.com/d4e093476e0c2843c11494e87dda1da9b77f03ca
Cr-Commit-Position: refs/heads/master@{#367304}

[rune, 2016-01-04 09:09:54]

https://codereview.chromium.org/1552703003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/printing/page-height-zero.html (right):

https://codereview.chromium.org/1552703003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/printing/page-height-zero.html:18:
internals.numberOfPages(100, 0);
Why not use js-test.js which does dumpAsText(), logging, and try-catch inside
shouldThrow() for you instead?

[mstensho (USE GERRIT), 2016-01-04 09:36:08]

https://codereview.chromium.org/1552703003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/printing/page-height-zero.html (right):

https://codereview.chromium.org/1552703003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/printing/page-height-zero.html:18:
internals.numberOfPages(100, 0);
On 2016/01/04 09:09:54, rune wrote:
> Why not use js-test.js which does dumpAsText(), logging, and try-catch inside
> shouldThrow() for you instead?

Because js-test.js exceeded my expectations yet again. :)

Done.

[rune, 2016-01-04 10:25:07]

lgtm

[mstensho (USE GERRIT), 2016-01-04 10:38:14]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-01-04 10:38:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552703003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552703003/20001

[commit-bot: I haz the power, 2016-01-04 13:44:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-04 13:45:24]

Description was changed from

==========
Internals: throw an exception when page height or width is 0.

The two methods pageNumber() and numberOfPages() on the window.internals object
allowed 0 as page height, which results in a division by zero in multicol (and
general failure to paginate in other parts of the code). Have the methods raise
an exception when such values are provided. Also specify the default width and
height values in Internals.idl rather than in Internals.h, so that they
actually do something. Our default page width and height were effectively 0 for
these methods.

Assert that width and height have valid values (i.e. greater than 0) in
PrintContext::begin().

BUG=571348
R=rune@opera.com
==========

to

==========
Internals: throw an exception when page height or width is 0.

The two methods pageNumber() and numberOfPages() on the window.internals object
allowed 0 as page height, which results in a division by zero in multicol (and
general failure to paginate in other parts of the code). Have the methods raise
an exception when such values are provided. Also specify the default width and
height values in Internals.idl rather than in Internals.h, so that they
actually do something. Our default page width and height were effectively 0 for
these methods.

Assert that width and height have valid values (i.e. greater than 0) in
PrintContext::begin().

BUG=571348
R=rune@opera.com

Committed: https://crrev.com/d4e093476e0c2843c11494e87dda1da9b77f03ca
Cr-Commit-Position: refs/heads/master@{#367304}
==========

[commit-bot: I haz the power, 2016-01-04 13:45:25]

Patchset 2 (id:??) landed as
https://crrev.com/d4e093476e0c2843c11494e87dda1da9b77f03ca
Cr-Commit-Position: refs/heads/master@{#367304}