third_party/WebKit/Source/core/testing/Internals.h - Issue 1552703003: Internals: throw an exception when page height or width is 0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/Internals.h

Issue 1552703003: Internals: throw an exception when page height or width is 0. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use js-test.js , which provides shouldThrow() Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/testing/Internals.h

diff --git a/third_party/WebKit/Source/core/testing/Internals.h b/third_party/WebKit/Source/core/testing/Internals.h

index f1ad183d33d683ff3bf1ba0e0e46538a24c744a0..c535dab8b2dafb71409281cdc6c9e163a69eff43 100644

--- a/third_party/WebKit/Source/core/testing/Internals.h

+++ b/third_party/WebKit/Source/core/testing/Internals.h

@@ -249,11 +249,11 @@ public:

String counterValue(Element*);

- int pageNumber(Element*, float pageWidth = 800, float pageHeight = 600);

+ int pageNumber(Element*, float pageWidth, float pageHeight, ExceptionState&);

Vector<String> shortcutIconURLs(Document*) const;

Vector<String> allIconURLs(Document*) const;

- int numberOfPages(float pageWidthInPixels = 800, float pageHeightInPixels = 600);

+ int numberOfPages(float pageWidthInPixels, float pageHeightInPixels, ExceptionState&);

String pageProperty(String, int, ExceptionState& = ASSERT_NO_EXCEPTION) const;

String pageSizeAndMarginsInPixels(int, int, int, int, int, int, int, ExceptionState& = ASSERT_NO_EXCEPTION) const;

« no previous file with comments | « third_party/WebKit/Source/core/page/PrintContext.cpp ('k') | third_party/WebKit/Source/core/testing/Internals.cpp » ('j') | no next file with comments »