Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 1552693002: Add paint testing mode subsequence_caching_disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveSyncPaint
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
index 8bdfeae8142ac2694e4e9b04057e3c10cf48c655..7b0050b2a904962ece70e6cba441e086c2846108 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
@@ -130,6 +130,9 @@ public:
bool displayItemConstructionIsDisabled() const { return m_constructionDisabled; }
void setDisplayItemConstructionIsDisabled(const bool disable) { m_constructionDisabled = disable; }
+ bool subsequenceCachingIsDisabled() const { return m_subsequenceCachingDisabled; }
chrishtr 2016/01/04 17:32:08 Add a comment that these are used only benchmarkin
Xianzhu 2016/01/04 17:39:55 Done.
+ void setSubsequenceCachingIsDisabled(bool disable) { m_subsequenceCachingDisabled = disable; }
+
bool textPainted() const { return m_textPainted; }
void setTextPainted() { m_textPainted = true; }
bool imagePainted() const { return m_imagePainted; }
@@ -181,6 +184,7 @@ protected:
: m_newDisplayItemList(kInitialDisplayItemListCapacityBytes)
, m_validlyCachedClientsDirty(false)
, m_constructionDisabled(false)
+ , m_subsequenceCachingDisabled(false)
, m_textPainted(false)
, m_imagePainted(false)
, m_skippingCacheCount(0)
@@ -251,6 +255,9 @@ private:
// in performance metrics.
bool m_constructionDisabled;
+ // Allow subsequence caching to be disabled to test the cost of display item caching.
+ bool m_subsequenceCachingDisabled;
+
// Indicates this PaintController has ever had text. It is never reset to false.
bool m_textPainted;
bool m_imagePainted;

Powered by Google App Engine
This is Rietveld 408576698