Add paint testing mode subsequence_caching_disabled

third_party/WebKit/Source/platform/graphics/paint/PaintController.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaintController_h
 #define PaintController_h
 
 #include "platform/PlatformExport.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/geometry/IntRect.h"
@@ skipping 112 matching lines @@
     const PaintArtifact& paintArtifact() const;
     const DisplayItemList& displayItemList() const { return paintArtifact().displayItemList(); }
     const Vector<PaintChunk>& paintChunks() const { return paintArtifact().paintChunks(); }
 
     bool clientCacheIsValid(const DisplayItemClient&) const;
     bool cacheIsEmpty() const { return m_currentPaintArtifact.isEmpty(); }
 
     bool displayItemConstructionIsDisabled() const { return m_constructionDisabled; }
     void setDisplayItemConstructionIsDisabled(const bool disable) { m_constructionDisabled = disable; }
 
+    bool subsequenceCachingIsDisabled() const { return m_subsequenceCachingDisabled; }

[chrishtr, 2016/01/04 17:32:08]

Add a comment that these are used only benchmarking. Group with lines 130-131 to
indicate that
for those lines too.

[Xianzhu, 2016/01/04 17:39:55]

Done.

+    void setSubsequenceCachingIsDisabled(bool disable) { m_subsequenceCachingDisabled = disable; }
+
     bool textPainted() const { return m_textPainted; }
     void setTextPainted() { m_textPainted = true; }
     bool imagePainted() const { return m_imagePainted; }
     void setImagePainted() { m_imagePainted = true; }
 
     // Returns displayItemList added using createAndAppend() since beginning or
     // the last commitNewDisplayItems(). Use with care.
     DisplayItemList& newDisplayItemList() { return m_newDisplayItemList; }
 
 #ifndef NDEBUG
@@ skipping 31 matching lines @@
 
 #if ENABLE(ASSERT)
     void assertDisplayItemClientsAreLive();
 #endif
 
 protected:
     PaintController()
         : m_newDisplayItemList(kInitialDisplayItemListCapacityBytes)
         , m_validlyCachedClientsDirty(false)
         , m_constructionDisabled(false)
+        , m_subsequenceCachingDisabled(false)
         , m_textPainted(false)
         , m_imagePainted(false)
         , m_skippingCacheCount(0)
         , m_numCachedNewItems(0)
         , m_nextScope(1) { }
 
 private:
     // Set new item state (scopes, cache skipping, etc) for a new item.
     void processNewItem(DisplayItem&);
 
@@ skipping 50 matching lines @@
 #if ENABLE(ASSERT)
     // Set of clients which had paint offset changes since the last commit. This is used for
     // ensuring paint offsets are only updated once and are the same in all phases.
     HashSet<const DisplayItemClient*> m_clientsWithPaintOffsetInvalidations;
 #endif
 
     // Allow display item construction to be disabled to isolate the costs of construction
     // in performance metrics.
     bool m_constructionDisabled;
 
+    // Allow subsequence caching to be disabled to test the cost of display item caching.
+    bool m_subsequenceCachingDisabled;
+
     // Indicates this PaintController has ever had text. It is never reset to false.
     bool m_textPainted;
     bool m_imagePainted;
 
     int m_skippingCacheCount;
 
     int m_numCachedNewItems;
 
     unsigned m_nextScope;
     Vector<unsigned> m_scopeStack;
 
 #if ENABLE(ASSERT)
     // Record the debug names of invalidated clients for assertion and debugging.
     Vector<String> m_invalidations;
 
     // This is used to check duplicated ids during add(). We could also check
     // during commitNewDisplayItems(), but checking during add() helps developer
     // easily find where the duplicated ids are from.
     DisplayItemIndicesByClientMap m_newDisplayItemIndicesByClient;
 #endif
 
     OwnPtr<Vector<String>> m_trackedPaintInvalidationObjects;
 };
 
 } // namespace blink
 
 #endif // PaintController_h