[Sync] Add comment that ClientToServerMessage.share can be empty.

[Sync] Add comment that ClientToServerMessage.share can be empty.

Adding comment that share can be empty.
Timon asked me to do this.

R=zea@chromium.org
BUG=

Committed: https://crrev.com/915d03c8e2b666f07158527a0772b6234edd412b
Cr-Commit-Position: refs/heads/master@{#367383}

[Nicolas Zea, 2015-12-30 20:16:23]

https://codereview.chromium.org/1552623002/diff/1/sync/protocol/sync.proto
File sync/protocol/sync.proto (right):

https://codereview.chromium.org/1552623002/diff/1/sync/protocol/sync.proto#ne...
sync/protocol/sync.proto:734: // contain empty string. It should be deprecated.
Could you mention also what's preventing us from deprecating this now?

[pavely, 2016-01-04 19:03:59]

Description was changed from

==========
[Sync] Add comment to deprecate ClientToServerMessage.share field

Adding comment that share can be empty and should be deprecated.
Timon asked me to add this comment.

R=zea@chromium.org
BUG=
==========

to

==========
[Sync] Add comment that ClientToServerMessage.share can be empty.

Adding comment that share can be empty.
Timon asked me to do this.

R=zea@chromium.org
BUG=
==========

[pavely, 2016-01-04 19:05:17]

https://codereview.chromium.org/1552623002/diff/1/sync/protocol/sync.proto
File sync/protocol/sync.proto (right):

https://codereview.chromium.org/1552623002/diff/1/sync/protocol/sync.proto#ne...
sync/protocol/sync.proto:734: // contain empty string. It should be deprecated.
On 2015/12/30 20:16:23, Nicolas Zea wrote:
> Could you mention also what's preventing us from deprecating this now?

I've updated comment. We shouldn't actually deprecate it yet. This field allows
to log username when access token is invalid.

[Nicolas Zea, 2016-01-04 19:06:15]

lgtm

[pavely, 2016-01-04 19:08:33]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2016-01-04 19:09:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552623002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552623002/20001

[commit-bot: I haz the power, 2016-01-04 21:55:20]

Description was changed from

==========
[Sync] Add comment that ClientToServerMessage.share can be empty.

Adding comment that share can be empty.
Timon asked me to do this.

R=zea@chromium.org
BUG=
==========

to

==========
[Sync] Add comment that ClientToServerMessage.share can be empty.

Adding comment that share can be empty.
Timon asked me to do this.

R=zea@chromium.org
BUG=
==========

[commit-bot: I haz the power, 2016-01-04 21:55:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-04 21:56:04]

Description was changed from

==========
[Sync] Add comment that ClientToServerMessage.share can be empty.

Adding comment that share can be empty.
Timon asked me to do this.

R=zea@chromium.org
BUG=
==========

to

==========
[Sync] Add comment that ClientToServerMessage.share can be empty.

Adding comment that share can be empty.
Timon asked me to do this.

R=zea@chromium.org
BUG=

Committed: https://crrev.com/915d03c8e2b666f07158527a0772b6234edd412b
Cr-Commit-Position: refs/heads/master@{#367383}
==========

[commit-bot: I haz the power, 2016-01-04 21:56:07]

Patchset 2 (id:??) landed as
https://crrev.com/915d03c8e2b666f07158527a0772b6234edd412b
Cr-Commit-Position: refs/heads/master@{#367383}