Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: sync/protocol/sync.proto

Issue 1552623002: [Sync] Add comment that ClientToServerMessage.share can be empty. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol for communication between sync client and server. 5 // Sync protocol for communication between sync client and server.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
(...skipping 712 matching lines...) Expand 10 before | Expand all | Expand 10 after
723 message DataTypeContext { 723 message DataTypeContext {
724 // The type this context is associated with. 724 // The type this context is associated with.
725 optional int32 data_type_id = 1; 725 optional int32 data_type_id = 1;
726 // The context for the datatype. 726 // The context for the datatype.
727 optional bytes context = 2; 727 optional bytes context = 2;
728 // The version of the context. 728 // The version of the context.
729 optional int64 version = 3; 729 optional int64 version = 3;
730 } 730 }
731 731
732 message ClientToServerMessage { 732 message ClientToServerMessage {
733 // |share| field is only used on the server for logging and can sometimes
734 // contain empty string. It is still useful for logging username when it can't
735 // be derived from access token in case of auth error.
733 required string share = 1; 736 required string share = 1;
737
734 optional int32 protocol_version = 2 [default = 45]; 738 optional int32 protocol_version = 2 [default = 45];
735 enum Contents { 739 enum Contents {
736 COMMIT = 1; 740 COMMIT = 1;
737 GET_UPDATES = 2; 741 GET_UPDATES = 2;
738 AUTHENTICATE = 3; 742 AUTHENTICATE = 3;
739 DEPRECATED_4 = 4; 743 DEPRECATED_4 = 4;
740 CLEAR_SERVER_DATA = 5; 744 CLEAR_SERVER_DATA = 5;
741 } 745 }
742 746
743 // Each ClientToServerMessage contains one request defined by the 747 // Each ClientToServerMessage contains one request defined by the
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
1019 }; 1023 };
1020 1024
1021 // A message indicating that the sync engine has been disabled on a client. 1025 // A message indicating that the sync engine has been disabled on a client.
1022 message SyncDisabledEvent { 1026 message SyncDisabledEvent {
1023 // The GUID that identifies the sync client. 1027 // The GUID that identifies the sync client.
1024 optional string cache_guid = 1; 1028 optional string cache_guid = 1;
1025 1029
1026 // The store birthday that the client was using before disabling sync. 1030 // The store birthday that the client was using before disabling sync.
1027 optional string store_birthday = 2; 1031 optional string store_birthday = 2;
1028 }; 1032 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698