Remove needless move() calls in cloud_print/gcp20

Remove needless move() calls in cloud_print/gcp20

After https://codereview.chromium.org/1553493002/, the compiler can
inform us that these are not needed and in fact harmful:

..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
  return std::move(response);
         ^
..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  note: remove std::move call here
  return std::move(response);
         ^~~~~~~~~~

..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16) :  error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
    context_ = std::move(builder.Build());
               ^
..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16) :  note: remove std::move call here
    context_ = std::move(builder.Build());
               ^~~~~~~~~~               ~

BUG=82385
TBR=vitalybuka

Committed: https://crrev.com/c95337d638df3289758257448a90556e9fcdd071
Cr-Commit-Position: refs/heads/master@{#367067}

[Nico, 2015-12-29 14:19:20]

Description was changed from

==========
Remove needless move() calls in cloud_print/gcp20

After https://codereview.chromium.org/1553493002/, the compiler can
inform us that these are not needed and in fact harmful:

..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  error: moving
a local object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
  return std::move(response);
         ^
..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  note: remove
std::move call here
  return std::move(response);
         ^~~~~~~~~~


..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16)
:  error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
    context_ = std::move(builder.Build());
               ^
..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16)
:  note: remove std::move call here
    context_ = std::move(builder.Build());
               ^~~~~~~~~~               ~

BUG=82385
==========

to

==========
Remove needless move() calls in cloud_print/gcp20

After https://codereview.chromium.org/1553493002/, the compiler can
inform us that these are not needed and in fact harmful:

..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  error: moving
a local object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
  return std::move(response);
         ^
..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  note: remove
std::move call here
  return std::move(response);
         ^~~~~~~~~~


..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16)
:  error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
    context_ = std::move(builder.Build());
               ^
..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16)
:  note: remove std::move call here
    context_ = std::move(builder.Build());
               ^~~~~~~~~~               ~

BUG=82385
TBR=vitalybuka
==========

[Nico, 2015-12-29 14:19:57]

thakis@chromium.org changed reviewers:
+ vitalybuka@chromium.org

[Nico, 2015-12-29 14:19:57]

This target doesn't seem to be depended by anything from what I can tell --
maybe we should just delete all the gcp20 code?

[Nico, 2015-12-29 14:20:30]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-29 14:20:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1552613003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1552613003/1

[commit-bot: I haz the power, 2015-12-29 14:32:56]

Description was changed from

==========
Remove needless move() calls in cloud_print/gcp20

After https://codereview.chromium.org/1553493002/, the compiler can
inform us that these are not needed and in fact harmful:

..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  error: moving
a local object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
  return std::move(response);
         ^
..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  note: remove
std::move call here
  return std::move(response);
         ^~~~~~~~~~


..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16)
:  error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
    context_ = std::move(builder.Build());
               ^
..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16)
:  note: remove std::move call here
    context_ = std::move(builder.Build());
               ^~~~~~~~~~               ~

BUG=82385
TBR=vitalybuka
==========

to

==========
Remove needless move() calls in cloud_print/gcp20

After https://codereview.chromium.org/1553493002/, the compiler can
inform us that these are not needed and in fact harmful:

..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  error: moving
a local object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
  return std::move(response);
         ^
..\..\cloud_print\gcp20\prototype\privet_http_server.cc(418,10) :  note: remove
std::move call here
  return std::move(response);
         ^~~~~~~~~~

..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16)
:  error: moving a temporary object prevents copy elision
[-Werror,-Wpessimizing-move]
    context_ = std::move(builder.Build());
               ^
..\..\cloud_print\gcp20\prototype\cloud_print_url_request_context_getter.cc(30,16)
:  note: remove std::move call here
    context_ = std::move(builder.Build());
               ^~~~~~~~~~               ~

BUG=82385
TBR=vitalybuka

Committed: https://crrev.com/c95337d638df3289758257448a90556e9fcdd071
Cr-Commit-Position: refs/heads/master@{#367067}
==========

[commit-bot: I haz the power, 2015-12-29 14:32:56]

Patchset 1 (id:??) landed as
https://crrev.com/c95337d638df3289758257448a90556e9fcdd071
Cr-Commit-Position: refs/heads/master@{#367067}