Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1552603002:
Support loading complete linearized PDF. (Closed)
DescriptionSupport loading complete linearized PDF.
Previously, if a linearized PDF was loaded in a single callback (i.e. if
IsDocumentComplete was true in the call to LoadDocument), only the first
page of the document was visible because FPDFAvail_IsPageAvail was never
called for all other pages. This has been corrected.
BUG=572655
Committed: https://crrev.com/9a86df9f426485f774579ae073de5facedfb940d
Cr-Commit-Position: refs/heads/master@{#367046}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Fix comment #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Support loading complete linearized PDF. Previously, if a linearized PDF was loaded in a single callback (i.e. if IsDocumentComplete was true in the call to LoadDocument), only the first page of the document was visible because FPDFAvail_IsPageAvail was never called. This has been corrected. BUG=572655 ========== to ========== Support loading complete linearized PDF. Previously, if a linearized PDF was loaded in a single callback (i.e. if IsDocumentComplete was true in the call to LoadDocument), only the first page of the document was visible because FPDFAvail_IsPageAvail was never called. This has been corrected. BUG=572655 ==========
spelchat@chromium.org changed reviewers: + thestig@chromium.org
In the CL description: "because FPDFAvail_IsPageAvail was never called" -> "because FPDFAvail_IsPageAvail was never called for all other pages" ? https://codereview.chromium.org/1552603002/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1552603002/diff/1/pdf/pdfium/pdfium_engine.cc... pdf/pdfium/pdfium_engine.cc:2671: // The page is marked as not being available even if doc_complete is true Please refer to variables are |var_name|. https://codereview.chromium.org/1552603002/diff/1/pdf/pdfium/pdfium_engine.cc... pdf/pdfium/pdfium_engine.cc:2672: // because FPDFAvail_IsPageAvail still has to be called for this page, If you refer to functions as FuncName(), then it's clear to readers that you are referring to a function and not a class. Readers may not be familiar with the functions you are referring to.
Description was changed from ========== Support loading complete linearized PDF. Previously, if a linearized PDF was loaded in a single callback (i.e. if IsDocumentComplete was true in the call to LoadDocument), only the first page of the document was visible because FPDFAvail_IsPageAvail was never called. This has been corrected. BUG=572655 ========== to ========== Support loading complete linearized PDF. Previously, if a linearized PDF was loaded in a single callback (i.e. if IsDocumentComplete was true in the call to LoadDocument), only the first page of the document was visible because FPDFAvail_IsPageAvail was never called for all other pages. This has been corrected. BUG=572655 ==========
https://codereview.chromium.org/1552603002/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/1552603002/diff/1/pdf/pdfium/pdfium_engine.cc... pdf/pdfium/pdfium_engine.cc:2671: // The page is marked as not being available even if doc_complete is true On 2015/12/28 23:55:02, Lei Zhang wrote: > Please refer to variables are |var_name|. Done. https://codereview.chromium.org/1552603002/diff/1/pdf/pdfium/pdfium_engine.cc... pdf/pdfium/pdfium_engine.cc:2672: // because FPDFAvail_IsPageAvail still has to be called for this page, On 2015/12/28 23:55:02, Lei Zhang wrote: > If you refer to functions as FuncName(), then it's clear to readers that you are > referring to a function and not a class. Readers may not be familiar with the > functions you are referring to. Done.
lgtm
The CQ bit was checked by spelchat@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552603002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552603002/20001
Message was sent while issue was closed.
Description was changed from ========== Support loading complete linearized PDF. Previously, if a linearized PDF was loaded in a single callback (i.e. if IsDocumentComplete was true in the call to LoadDocument), only the first page of the document was visible because FPDFAvail_IsPageAvail was never called for all other pages. This has been corrected. BUG=572655 ========== to ========== Support loading complete linearized PDF. Previously, if a linearized PDF was loaded in a single callback (i.e. if IsDocumentComplete was true in the call to LoadDocument), only the first page of the document was visible because FPDFAvail_IsPageAvail was never called for all other pages. This has been corrected. BUG=572655 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Support loading complete linearized PDF. Previously, if a linearized PDF was loaded in a single callback (i.e. if IsDocumentComplete was true in the call to LoadDocument), only the first page of the document was visible because FPDFAvail_IsPageAvail was never called for all other pages. This has been corrected. BUG=572655 ========== to ========== Support loading complete linearized PDF. Previously, if a linearized PDF was loaded in a single callback (i.e. if IsDocumentComplete was true in the call to LoadDocument), only the first page of the document was visible because FPDFAvail_IsPageAvail was never called for all other pages. This has been corrected. BUG=572655 Committed: https://crrev.com/9a86df9f426485f774579ae073de5facedfb940d Cr-Commit-Position: refs/heads/master@{#367046} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9a86df9f426485f774579ae073de5facedfb940d Cr-Commit-Position: refs/heads/master@{#367046} |
