Support loading complete linearized PDF.

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 1138 matching lines @@
                                 doc_loader_.document_size());
 }
 
 void PDFiumEngine::OnDocumentComplete() {
   if (!doc_ || !form_) {
     file_access_.m_FileLen = doc_loader_.document_size();
     LoadDocument();
     return;
   }
 
+  FinishLoadingDocument();
+}
+
+void PDFiumEngine::FinishLoadingDocument() {
+  DCHECK(doc_loader_.IsDocumentComplete() && doc_);
+
   bool need_update = false;
   for (size_t i = 0; i < pages_.size(); ++i) {
     if (pages_[i]->available())
       continue;
 
     pages_[i]->set_available(true);
     // We still need to call IsPageAvail() even if the whole document is
     // already downloaded.
     FPDFAvail_IsPageAvail(fpdf_availability_, i, &download_hints_);
     need_update = true;
     if (IsPageVisible(i))
       client_->Invalidate(GetPageScreenRect(i));
   }
   if (need_update)
     LoadPageInfo(true);
 
-  FinishLoadingDocument();
-}
-
-void PDFiumEngine::FinishLoadingDocument() {
-  DCHECK(doc_loader_.IsDocumentComplete() && doc_);
   if (called_do_document_action_)
     return;
   called_do_document_action_ = true;
 
   // These can only be called now, as the JS might end up needing a page.
   FORM_DoDocumentJSAction(form_);
   FORM_DoDocumentOpenAction(form_);
   if (most_visible_page_ != -1) {
     FPDF_PAGE new_page = pages_[most_visible_page_]->GetPage();
     FORM_DoPageAAction(new_page, form_, FPDFPAGE_AACTION_OPEN);
@@ skipping 1470 matching lines @@
 
   for (int i = 0; i < page_count; ++i) {
     // Center pages relative to the entire document.
     page_rects[i].set_x((document_size_.width() - page_rects[i].width()) / 2);
     pp::Rect page_rect(page_rects[i]);
     page_rect.Inset(kPageShadowLeft, kPageShadowTop,
                     kPageShadowRight, kPageShadowBottom);
     if (reload) {
       pages_[i]->set_rect(page_rect);
     } else {
-      pages_.push_back(new PDFiumPage(this, i, page_rect, doc_complete));
+      // The page is marked as not being available even if doc_complete is true

[Lei Zhang, 2015/12/28 23:55:02]

Please refer to variables are |var_name|.

[spelchat, 2015/12/29 00:04:03]

Done.

+      // because FPDFAvail_IsPageAvail still has to be called for this page,

[Lei Zhang, 2015/12/28 23:55:02]

If you refer to functions as FuncName(), then it's clear to readers that you are
referring to a function and not a class. Readers may not be familiar with the
functions you are referring to.

[spelchat, 2015/12/29 00:04:03]

Done.

+      // which will be done in FinishLoadingDocument.
+      pages_.push_back(new PDFiumPage(this, i, page_rect, false));
     }
   }
 
   CalculateVisiblePages();
   if (document_size_ != old_document_size)
     client_->DocumentSizeUpdated(document_size_);
 }
 
 void PDFiumEngine::CalculateVisiblePages() {
   // Clear pending requests queue, since it may contain requests to the pages
@@ skipping 1318 matching lines @@
     double* height) {
   FPDF_DOCUMENT doc = FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, NULL);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf