Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1552303002: Add unit test for crbug.com/570232 (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add unit test for crbug.com/570232 This is the promised followup to https://codereview.chromium.org/1539553002/ (Add default ctor to SkMask) and would've caught the bug before it got out into the wild. BUG=570232 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1552303002 Committed: https://skia.googlesource.com/skia/+/4abb0c11da669a40d126c6b7698e37732e052d84

Patch Set 1 #

Patch Set 2 : Fix overlength line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M tests/BlurTest.cpp View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
robertphillips
4 years, 11 months ago (2016-01-04 18:35:51 UTC) #4
reed1
lgtm
4 years, 11 months ago (2016-01-04 18:40:05 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552303002/20001
4 years, 11 months ago (2016-01-04 19:02:19 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 19:18:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1552303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1552303002/20001
4 years, 11 months ago (2016-01-04 19:19:53 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 19:20:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4abb0c11da669a40d126c6b7698e37732e052d84

Powered by Google App Engine
This is Rietveld 408576698