Flag and whitelist to allow crxfs api in NaCl

chrome/browser/pepper_util.h

Index: chrome/browser/pepper_util.h
diff --git a/chrome/browser/pepper_util.h b/chrome/browser/pepper_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..d617571af431529282005d1e2e5fa7893e80cb7e
--- /dev/null
+++ b/chrome/browser/pepper_util.h
@@ -0,0 +1,25 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PEPPER_UTIL_H_

[yzshen1, 2013/05/22 18:14:23]

nit: maybe a more specific name such as pepper_permission_util.h?

[victorhsieh, 2013/05/22 19:47:33]

Sometimes I saw this kind of util file ends up with only a few function in it. 
And sometimes there are several small util files in one directory.  I'm not sure
this is good, so I chose a broad name and thought we could split later if the
file grows bigger.

But it's up to you.  Having a specific filename can be good as the future reader
won't have to open the file to know what it is about.

[yzshen1, 2013/05/22 20:12:47]

I think it is better to have a more specific name for now.
It is easier to understand what the file is about.


On 2013/05/22 19:47:33, victorhsieh wrote:

[victorhsieh, 2013/05/22 20:52:22]

Done.

+#define CHROME_BROWSER_PEPPER_UTIL_H_
+
+#include <set>
+#include <string>
+
+class GURL;
+class Profile;
+
+namespace chrome {
+
+// Returns true if the extension or it's shared module is whitelisted, or
+// appears in command_line_switch.
+bool IsExtensionOrSharedModuleWhitelisted(Profile* profile,
+                                          const GURL& url,
+                                          std::set<std::string> whitelist,

[yzshen1, 2013/05/22 18:14:23]

const &, please.

[victorhsieh, 2013/05/22 19:47:33]

Done.

+                                          const char command_line_switch[]);

[yzshen1, 2013/05/22 18:14:23]

It seems better to use const char*.

[victorhsieh, 2013/05/22 19:47:33]

Done.

+
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_PEPPER_UTIL_H_