chrome/browser/pepper_util.h - Issue 15521002: Flag and whitelist to allow crxfs api in NaCl

Side by Side Diff: chrome/browser/pepper_util.h

Issue 15521002: Flag and whitelist to allow crxfs api in NaCl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PEPPER_UTIL_H_
	yzshen1 2013/05/22 18:14:23 nit: maybe a more specific name such as pepper_per nit: maybe a more specific name such as pepper_permission_util.h? victorhsieh 2013/05/22 19:47:33 Sometimes I saw this kind of util file ends up wit Show quoted text On 2013/05/22 18:14:23, yzshen1 wrote: > nit: maybe a more specific name such as pepper_permission_util.h? Sometimes I saw this kind of util file ends up with only a few function in it. And sometimes there are several small util files in one directory. I'm not sure this is good, so I chose a broad name and thought we could split later if the file grows bigger. But it's up to you. Having a specific filename can be good as the future reader won't have to open the file to know what it is about. yzshen1 2013/05/22 20:12:47 I think it is better to have a more specific name I think it is better to have a more specific name for now. It is easier to understand what the file is about. On 2013/05/22 19:47:33, victorhsieh wrote: Show quoted text > On 2013/05/22 18:14:23, yzshen1 wrote: > > nit: maybe a more specific name such as pepper_permission_util.h? > > Sometimes I saw this kind of util file ends up with only a few function in it. > And sometimes there are several small util files in one directory. I'm not sure > this is good, so I chose a broad name and thought we could split later if the > file grows bigger. > > But it's up to you. Having a specific filename can be good as the future reader > won't have to open the file to know what it is about. victorhsieh 2013/05/22 20:52:22 Done. Show quoted text On 2013/05/22 20:12:47, yzshen1 wrote: > I think it is better to have a more specific name for now. > It is easier to understand what the file is about. > > > On 2013/05/22 19:47:33, victorhsieh wrote: > > On 2013/05/22 18:14:23, yzshen1 wrote: > > > nit: maybe a more specific name such as pepper_permission_util.h? > > > > Sometimes I saw this kind of util file ends up with only a few function in it. > > > And sometimes there are several small util files in one directory. I'm not > sure > > this is good, so I chose a broad name and thought we could split later if the > > file grows bigger. > > > > But it's up to you. Having a specific filename can be good as the future > reader > > won't have to open the file to know what it is about. > Done.
	6 #define CHROME_BROWSER_PEPPER_UTIL_H_

	7

	8 #include <set>

	9 #include <string>

	10

	11 class GURL;

	12 class Profile;

	13

	14 namespace chrome {

	15

	16 // Returns true if the extension or it's shared module is whitelisted, or

	17 // appears in command_line_switch.

	18 bool IsExtensionOrSharedModuleWhitelisted(Profile* profile,

	19 const GURL& url,

	20 std::set<std::string> whitelist,
	yzshen1 2013/05/22 18:14:23 const &, please. const &, please. victorhsieh 2013/05/22 19:47:33 Done. Show quoted text On 2013/05/22 18:14:23, yzshen1 wrote: > const &, please. Done.
	21 const char command_line_switch[]);
	yzshen1 2013/05/22 18:14:23 It seems better to use const char. It seems better to use const char. victorhsieh 2013/05/22 19:47:33 Done. Show quoted text On 2013/05/22 18:14:23, yzshen1 wrote: > It seems better to use const char*. Done.
	22

	23 } // namespace chrome

	24

	25 #endif // CHROME_BROWSER_PEPPER_UTIL_H_

OLD	NEW

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/pepper_util.cc » ('j') | chrome/browser/pepper_util.cc » ('J')