Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: base/mac/scoped_nsobject_unittest.mm

Issue 1551943002: Rewrite most of the scopers in //base/mac to use ScopedTypeRef or ScopedGeneric. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix iOS Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/mac/scoped_nsobject_unittest.mm
diff --git a/base/mac/scoped_nsobject_unittest.mm b/base/mac/scoped_nsobject_unittest.mm
index 933a3395b2c175a5e1eb79690eefe6fe35063b5f..c838217a9eec1e720bc10da5c5394df0f1b60adf 100644
--- a/base/mac/scoped_nsobject_unittest.mm
+++ b/base/mac/scoped_nsobject_unittest.mm
@@ -52,6 +52,12 @@ TEST(ScopedNSObjectTest, ScopedNSObject) {
ASSERT_EQ(2u, [p1 retainCount]);
}
+#if 0
Nico 2016/01/05 16:18:30 ?
Robert Sesek 2016/01/05 16:26:10 It's for testing a static_assert.
Nico 2016/01/05 16:38:39 This should have a comment saying so, else it's be
Robert Sesek 2016/01/05 17:35:03 Added a comment in https://codereview.chromium.org
+TEST(ScopedNSObjectTest, FailToCreateScopedNSObjectAutoreleasePool) {
+ base::scoped_nsobject<NSAutoreleasePool> pool;
+}
+#endif
+
TEST(ScopedNSObjectTest, ScopedNSObjectInContainer) {
base::scoped_nsobject<id> p([[NSObject alloc] init]);
ASSERT_TRUE(p.get());

Powered by Google App Engine
This is Rietveld 408576698