Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1563463002: Add a comment for the #if-0 block in scoped_nsobject_unittest.mm. (Closed)

Created:
4 years, 11 months ago by Robert Sesek
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a comment for the #if-0 block in scoped_nsobject_unittest.mm. Requested after-landing https://codereview.chromium.org/1551943002/. R=thakis@chromium.org Committed: https://crrev.com/06f11a1252cf7019186b64799d3a33630b12f221 Cr-Commit-Position: refs/heads/master@{#367573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M base/mac/scoped_nsobject_unittest.mm View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Robert Sesek
4 years, 11 months ago (2016-01-05 17:35:06 UTC) #1
Nico
nocompile tests are disabled by default, see https://www.chromium.org/developers/testing/no-compile-tests if you want to get them to ...
4 years, 11 months ago (2016-01-05 17:43:19 UTC) #3
Robert Sesek
On 2016/01/05 17:43:19, Nico wrote: > nocompile tests are disabled by default, see > https://www.chromium.org/developers/testing/no-compile-tests ...
4 years, 11 months ago (2016-01-05 17:46:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1563463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1563463002/1
4 years, 11 months ago (2016-01-05 17:47:00 UTC) #6
Robert Sesek
On 2016/01/05 17:46:13, Robert Sesek wrote: > On 2016/01/05 17:43:19, Nico wrote: > > nocompile ...
4 years, 11 months ago (2016-01-05 17:47:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 18:08:23 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 18:09:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06f11a1252cf7019186b64799d3a33630b12f221
Cr-Commit-Position: refs/heads/master@{#367573}

Powered by Google App Engine
This is Rietveld 408576698