third_party/WebKit/Source/platform/scroll/ScrollAnimator.h - Issue 1551933002: Fix retargeting of composited smooth scrolls from the main thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

Issue 1551933002: Fix retargeting of composited smooth scrolls from the main thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

index 5d8f20a3f84d00c41494120eae3ec0b660651b00..76443e2c1f6dd18e81d90c6365fda133763d3792 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimator.h

@@ -65,12 +65,12 @@ public:

protected:

OwnPtr<WebScrollOffsetAnimationCurve> m_animationCurve;

- double m_lastTickTime;

double m_startTime;

WTF::TimeFunction m_timeFunction;

private:

FloatPoint desiredTargetPosition() const;

+ bool registerAndScheduleAnimation();

jbroman 2015/12/30 20:42:52 nit: It's not obvious what returning true or false

skobes 2015/12/30 20:54:54 Done.

FloatPoint m_targetOffset;

};

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp » ('j') | no next file with comments »