Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: chromeos/system/statistics_provider.cc

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: thestig Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/crash/linux/dump_info.h ('k') | components/crash/content/app/breakpad_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/system/statistics_provider.cc
diff --git a/chromeos/system/statistics_provider.cc b/chromeos/system/statistics_provider.cc
index afa67ded6a9174cb6d09d1080c221b7bdaf29780..7d33b04c8d83452bae9409dedce096aa0ce87e5c 100644
--- a/chromeos/system/statistics_provider.cc
+++ b/chromeos/system/statistics_provider.cc
@@ -218,8 +218,7 @@ class StatisticsProviderImpl : public StatisticsProvider {
const base::DictionaryValue* GetRegionDictionary() const;
// Returns extractor from regional_data_extractors_ or nullptr.
- const RegionDataExtractor GetRegionalDataExtractor(
- const std::string& name) const;
+ RegionDataExtractor GetRegionalDataExtractor(const std::string& name) const;
bool load_statistics_started_;
NameValuePairsParser::NameValueMap machine_info_;
@@ -272,7 +271,7 @@ const base::DictionaryValue* StatisticsProviderImpl::GetRegionDictionary()
return region_dict;
}
-const StatisticsProviderImpl::RegionDataExtractor
+StatisticsProviderImpl::RegionDataExtractor
StatisticsProviderImpl::GetRegionalDataExtractor(
const std::string& name) const {
const auto it = regional_data_extractors_.find(name);
« no previous file with comments | « chromecast/crash/linux/dump_info.h ('k') | components/crash/content/app/breakpad_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698