chromecast/crash/linux/dump_info.h - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/crash/linux/dump_info.h

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: thestig Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/crash/linux/dump_info.h

diff --git a/chromecast/crash/linux/dump_info.h b/chromecast/crash/linux/dump_info.h

index a2256363d308ad5d073d3dd14fda9e134b84b2e1..08f0fb6a8591352b1cbd98a5cbc4cac68eea1250 100644

--- a/chromecast/crash/linux/dump_info.h

+++ b/chromecast/crash/linux/dump_info.h

@@ -62,7 +62,7 @@ class DumpInfo {

// }

scoped_ptr<base::Value> GetAsValue() const;

const MinidumpParams& params() const { return params_; }

- const bool valid() const { return valid_; }

+ bool valid() const { return valid_; }

private:

// Checks if parsed JSON in |value| is valid, if so populates the object's

« no previous file with comments | « chrome/browser/chromeos/file_system_provider/service_unittest.cc ('k') | chromeos/system/statistics_provider.cc » ('j') | no next file with comments »