Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chromecast/crash/linux/dump_info.h

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: thestig Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_CRASH_LINUX_DUMP_INFO_H_ 5 #ifndef CHROMECAST_CRASH_LINUX_DUMP_INFO_H_
6 #define CHROMECAST_CRASH_LINUX_DUMP_INFO_H_ 6 #define CHROMECAST_CRASH_LINUX_DUMP_INFO_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // "suffix": <suffix>, 55 // "suffix": <suffix>,
56 // "prev_app_name": <prev_app_name>, 56 // "prev_app_name": <prev_app_name>,
57 // "cur_app_name": <current_app_name>, 57 // "cur_app_name": <current_app_name>,
58 // "last_app_name": <last_app_name>, 58 // "last_app_name": <last_app_name>,
59 // "release_version": <release_version>, 59 // "release_version": <release_version>,
60 // "build_number": <build_number> 60 // "build_number": <build_number>
61 // "reason": <reason> 61 // "reason": <reason>
62 // } 62 // }
63 scoped_ptr<base::Value> GetAsValue() const; 63 scoped_ptr<base::Value> GetAsValue() const;
64 const MinidumpParams& params() const { return params_; } 64 const MinidumpParams& params() const { return params_; }
65 const bool valid() const { return valid_; } 65 bool valid() const { return valid_; }
66 66
67 private: 67 private:
68 // Checks if parsed JSON in |value| is valid, if so populates the object's 68 // Checks if parsed JSON in |value| is valid, if so populates the object's
69 // fields from |value|. 69 // fields from |value|.
70 bool ParseEntry(const base::Value* value); 70 bool ParseEntry(const base::Value* value);
71 bool SetDumpTimeFromString(const std::string& timestr); 71 bool SetDumpTimeFromString(const std::string& timestr);
72 72
73 std::string crashed_process_dump_; 73 std::string crashed_process_dump_;
74 std::string logfile_; 74 std::string logfile_;
75 time_t dump_time_; 75 time_t dump_time_;
76 MinidumpParams params_; 76 MinidumpParams params_;
77 bool valid_; 77 bool valid_;
78 78
79 DISALLOW_COPY_AND_ASSIGN(DumpInfo); 79 DISALLOW_COPY_AND_ASSIGN(DumpInfo);
80 }; 80 };
81 81
82 } // namespace chromecast 82 } // namespace chromecast
83 83
84 #endif // CHROMECAST_CRASH_LINUX_DUMP_INFO_H_ 84 #endif // CHROMECAST_CRASH_LINUX_DUMP_INFO_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/file_system_provider/service_unittest.cc ('k') | chromeos/system/statistics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698