Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: third_party/mach_override/mach_override.gyp

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, and no -Wextra for pnacl-clang in gn for now Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/mach_override/mach_override.gyp
diff --git a/third_party/mach_override/mach_override.gyp b/third_party/mach_override/mach_override.gyp
index b16df0b22824a0117885f91e0084a4a3512eb41d..7206a0a955fd666b33c2cc13cc21f5b5e815480f 100644
--- a/third_party/mach_override/mach_override.gyp
+++ b/third_party/mach_override/mach_override.gyp
@@ -47,6 +47,13 @@
# For UD_ASSERT(!"message");
'-Wstring-conversion',
],
+ 'clang_warning_flags': [
+ # syn.c contains a switch with an assert(false) in a default:
+ # block. In release builds, the function is missing a return.
+ '-Wno-return-type',
+ # Fires once in decode.c.
+ '-Wno-sometimes-uninitialized',
+ ],
},
},
{

Powered by Google App Engine
This is Rietveld 408576698