components/history/core/browser/android/android_history_types.h - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/android/android_history_types.h

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, and no -Wextra for pnacl-clang in gn for now Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/history/core/browser/android/android_history_types.h

diff --git a/components/history/core/browser/android/android_history_types.h b/components/history/core/browser/android/android_history_types.h

index 41fad30356a76e6e9783fd648164abd70e5e86cf..50cc545086f53fef90e63d92968e6f79ca875e16 100644

--- a/components/history/core/browser/android/android_history_types.h

+++ b/components/history/core/browser/android/android_history_types.h

@@ -127,7 +127,7 @@ class HistoryAndBookmarkRow {

set_value_explicitly(PARENT_ID);

parent_id_ = parent_id;

}

- const int64_t parent_id() const { return parent_id_; }

+ int64_t parent_id() const { return parent_id_; }

// The internal URLID

void set_url_id(URLID url_id) {

« build/common.gypi ('K') | « components/crash/content/app/breakpad_linux.cc ('k') | components/nacl/renderer/plugin/plugin.gypi » ('j') | components/nacl/renderer/plugin/plugin.gypi » ('J')