chrome/browser/android/offline_pages/offline_page_utils.cc - Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils.cc

Issue 1551753002: Build third-party code with -Wall, build chromium_code with -Wextra on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, and no -Wextra for pnacl-clang in gn for now Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/common.gypi ('K') | « chrome/browser/android/offline_pages/offline_page_utils.h ('k') | chrome/browser/chromeos/extensions/accessibility_features_apitest.cc » ('j') | components/nacl/renderer/plugin/plugin.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_utils.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils.cc b/chrome/browser/android/offline_pages/offline_page_utils.cc

index 6f4a624d4099e618f4428a922addb55485f70287..5fdaa58dc70b62369bd81c17c06306a6516c58c2 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils.cc

@@ -122,7 +122,7 @@ bool OfflinePageUtils::HasOfflinePageForOnlineURL(

}

// static

-const bool OfflinePageUtils::HasOfflinePages(

+bool OfflinePageUtils::HasOfflinePages(

content::BrowserContext* browser_context) {

DCHECK(browser_context);