Remove references to Profile from browser_context_keyed_service.

Remove references to Profile from browser_context_keyed_service.

BUG=227219
R=joi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201634

[Paweł Hajdan Jr., 2013-05-22 00:03:10]

Jói, this is not yet ready for final review. I have to finish fixing 80cols
issues and code formatting (alignment).

Please let me know if you see some more non-formatting changes/renames to be
done here.

[tfarina, 2013-05-22 00:28:02]

This is awesome Pawel! Thanks for doing this.

I just looked at the files with *bookmark*.

https://codereview.chromium.org/15517005/diff/1/chrome/browser/bookmarks/book...
File chrome/browser/bookmarks/bookmark_model_factory.cc (right):

https://codereview.chromium.org/15517005/diff/1/chrome/browser/bookmarks/book...
chrome/browser/bookmarks/bookmark_model_factory.cc:37:
BrowserContextDependencyManager::GetInstance()) {
indentation.

https://codereview.chromium.org/15517005/diff/1/chrome/browser/bookmarks/book...
File chrome/browser/bookmarks/bookmark_model_factory.h (right):

https://codereview.chromium.org/15517005/diff/1/chrome/browser/bookmarks/book...
chrome/browser/bookmarks/bookmark_model_factory.h:15: class BookmarkModel;
while you are here, could you sort this alphabetical?

https://codereview.chromium.org/15517005/diff/1/chrome/browser/sync/glue/book...
File chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc (right):

https://codereview.chromium.org/15517005/diff/1/chrome/browser/sync/glue/book...
chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc:57:
BrowserContextKeyedService* BuildBookmarkModel(content::BrowserContext* context)
{
indentation.

[Jói, 2013-05-22 00:30:20]

I looked only at //components/browser_context_keyed_service and I
don't see any wayward references to Profile.  I assume for the rest of
the code you've already grepped for ProfileKeyedService so no need to
do that manually.

Cheers,
Jói


On Tue, May 21, 2013 at 5:28 PM,  <tfarina@chromium.org> wrote:
> This is awesome Pawel! Thanks for doing this.
>
> I just looked at the files with *bookmark*.
>
>
>
>
>
https://codereview.chromium.org/15517005/diff/1/chrome/browser/bookmarks/book...
> File chrome/browser/bookmarks/bookmark_model_factory.cc (right):
>
>
https://codereview.chromium.org/15517005/diff/1/chrome/browser/bookmarks/book...
> chrome/browser/bookmarks/bookmark_model_factory.cc:37:
> BrowserContextDependencyManager::GetInstance()) {
> indentation.
>
>
https://codereview.chromium.org/15517005/diff/1/chrome/browser/bookmarks/book...
> File chrome/browser/bookmarks/bookmark_model_factory.h (right):
>
>
https://codereview.chromium.org/15517005/diff/1/chrome/browser/bookmarks/book...
> chrome/browser/bookmarks/bookmark_model_factory.h:15: class
> BookmarkModel;
> while you are here, could you sort this alphabetical?
>
>
https://codereview.chromium.org/15517005/diff/1/chrome/browser/sync/glue/book...
> File chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc
> (right):
>
>
https://codereview.chromium.org/15517005/diff/1/chrome/browser/sync/glue/book...
> chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc:57:
> BrowserContextKeyedService* BuildBookmarkModel(content::BrowserContext*
> context) {
> indentation.
>
> https://codereview.chromium.org/15517005/
>
> --
> You received this message because you are subscribed to the Google Groups
> "browser-components-watch" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to browser-components-watch+unsubscribe@chromium.org.
> To post to this group, send email to browser-components-watch@chromium.org.
> To view this discussion on the web visit
>
https://groups.google.com/a/chromium.org/d/msgid/browser-components-watch/089....
> For more options, visit
> https://groups.google.com/a/chromium.org/groups/opt_out.
>
>

[Paweł Hajdan Jr., 2013-05-22 19:26:22]

PTAL - this is now ready for review.

[Jói, 2013-05-22 22:15:14]

LGTM

You still have some variables named profile_dependency_manager_ (in
testing_profile.cc, maybe more places) which should be renamed.
Suggest doing in a follow-up if it's in multiple places.

On Wed, May 22, 2013 at 12:26 PM,  <phajdan.jr@chromium.org> wrote:
> PTAL - this is now ready for review.
>
> https://codereview.chromium.org/15517005/

[Paweł Hajdan Jr., 2013-05-22 23:25:59]

Committed patchset #2 manually as r201634.

[Timur Iskhodzhanov, 2013-05-28 12:55:41]

https://codereview.chromium.org/15517005/diff/7001/tools/valgrind/memcheck/su...
File tools/valgrind/memcheck/suppressions.txt (right):

https://codereview.chromium.org/15517005/diff/7001/tools/valgrind/memcheck/su...
tools/valgrind/memcheck/suppressions.txt:6821:
fun:_ZN26BrowserContextKeyedServiceFactory20GetServiceForBrowserContextEPN7content14BrowserContextEb
FYI mangled names require the number change when changing the length of the
symbols.