Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: chrome/browser/favicon/favicon_service_factory.cc

Issue 15517005: Remove references to Profile from browser_context_keyed_service. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase & style Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/favicon/favicon_service_factory.h" 5 #include "chrome/browser/favicon/favicon_service_factory.h"
6 6
7 #include "base/memory/singleton.h" 7 #include "base/memory/singleton.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/favicon/favicon_service.h" 9 #include "chrome/browser/favicon/favicon_service.h"
10 #include "chrome/browser/history/history_service.h" 10 #include "chrome/browser/history/history_service.h"
11 #include "chrome/browser/history/history_service_factory.h" 11 #include "chrome/browser/history/history_service_factory.h"
12 #include "chrome/common/pref_names.h" 12 #include "chrome/common/pref_names.h"
13 #include "components/browser_context_keyed_service/browser_context_dependency_ma nager.h" 13 #include "components/browser_context_keyed_service/browser_context_dependency_ma nager.h"
14 14
15 // static 15 // static
16 FaviconService* FaviconServiceFactory::GetForProfile( 16 FaviconService* FaviconServiceFactory::GetForProfile(
17 Profile* profile, Profile::ServiceAccessType sat) { 17 Profile* profile, Profile::ServiceAccessType sat) {
18 if (!profile->IsOffTheRecord()) { 18 if (!profile->IsOffTheRecord()) {
19 return static_cast<FaviconService*>( 19 return static_cast<FaviconService*>(
20 GetInstance()->GetServiceForProfile(profile, true)); 20 GetInstance()->GetServiceForBrowserContext(profile, true));
21 } else if (sat == Profile::EXPLICIT_ACCESS) { 21 } else if (sat == Profile::EXPLICIT_ACCESS) {
22 // Profile must be OffTheRecord in this case. 22 // Profile must be OffTheRecord in this case.
23 return static_cast<FaviconService*>( 23 return static_cast<FaviconService*>(
24 GetInstance()->GetServiceForProfile( 24 GetInstance()->GetServiceForBrowserContext(
25 profile->GetOriginalProfile(), true)); 25 profile->GetOriginalProfile(), true));
26 } 26 }
27 27
28 // Profile is OffTheRecord without access. 28 // Profile is OffTheRecord without access.
29 NOTREACHED() << "This profile is OffTheRecord"; 29 NOTREACHED() << "This profile is OffTheRecord";
30 return NULL; 30 return NULL;
31 } 31 }
32 32
33 // static 33 // static
34 FaviconServiceFactory* FaviconServiceFactory::GetInstance() { 34 FaviconServiceFactory* FaviconServiceFactory::GetInstance() {
35 return Singleton<FaviconServiceFactory>::get(); 35 return Singleton<FaviconServiceFactory>::get();
36 } 36 }
37 37
38 FaviconServiceFactory::FaviconServiceFactory() 38 FaviconServiceFactory::FaviconServiceFactory()
39 : ProfileKeyedServiceFactory("FaviconService", 39 : BrowserContextKeyedServiceFactory(
40 ProfileDependencyManager::GetInstance()) { 40 "FaviconService",
41 BrowserContextDependencyManager::GetInstance()) {
41 DependsOn(HistoryServiceFactory::GetInstance()); 42 DependsOn(HistoryServiceFactory::GetInstance());
42 } 43 }
43 44
44 FaviconServiceFactory::~FaviconServiceFactory() {} 45 FaviconServiceFactory::~FaviconServiceFactory() {}
45 46
46 ProfileKeyedService* FaviconServiceFactory::BuildServiceInstanceFor( 47 BrowserContextKeyedService* FaviconServiceFactory::BuildServiceInstanceFor(
47 content::BrowserContext* profile) const { 48 content::BrowserContext* profile) const {
48 HistoryService* history_service = HistoryServiceFactory::GetForProfile( 49 HistoryService* history_service = HistoryServiceFactory::GetForProfile(
49 static_cast<Profile*>(profile), Profile::EXPLICIT_ACCESS); 50 static_cast<Profile*>(profile), Profile::EXPLICIT_ACCESS);
50 return new FaviconService(history_service); 51 return new FaviconService(history_service);
51 } 52 }
52 53
53 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const { 54 bool FaviconServiceFactory::ServiceIsNULLWhileTesting() const {
54 return true; 55 return true;
55 } 56 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698