Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Unified Diff: blimp/net/blimp_message_pump.h

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002
Patch Set: Address haibinlu's feedback Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_message_pump.h
diff --git a/blimp/net/blimp_message_pump.h b/blimp/net/blimp_message_pump.h
index bf30e957aa628f416f600718900eee803f408628..5d8aaa77dc28637b7241daa84ce548faf7afc4da 100644
--- a/blimp/net/blimp_message_pump.h
+++ b/blimp/net/blimp_message_pump.h
@@ -50,6 +50,11 @@ class BLIMP_NET_EXPORT BlimpMessagePump {
void OnReadPacketComplete(int result);
// Callback when |processor_| finishes processing a BlimpMessage.
+ // Any values other than net::OK indicate that |processor_| has encountered an
+ // error that should be handled. Currently all errors will cause the
+ // connection to be dropped; in the future we will need to add more
+ // sophisticated error handling logic here.
+ // TODO(kmarshall): Improve error handling.
void OnProcessMessageComplete(int result);
PacketReader* reader_;

Powered by Google App Engine
This is Rietveld 408576698