Implementation and fixes for Blimp client/engine E2E communication.

blimp/net/blimp_message_pump.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_NET_BLIMP_MESSAGE_PUMP_H_
 #define BLIMP_NET_BLIMP_MESSAGE_PUMP_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 32 matching lines @@
   }
 
  private:
   // Read next packet from |reader_|.
   void ReadNextPacket();
 
   // Callback when next packet is ready in |buffer_|.
   void OnReadPacketComplete(int result);
 
   // Callback when |processor_| finishes processing a BlimpMessage.
+  // Any values other than net::OK indicate that |processor_| has encountered an
+  // error that should be handled. Currently all errors will cause the
+  // connection to be dropped; in the future we will need to add more
+  // sophisticated error handling logic here.
+  // TODO(kmarshall): Improve error handling.
   void OnProcessMessageComplete(int result);
 
   PacketReader* reader_;
   ConnectionErrorObserver* error_observer_ = nullptr;
   BlimpMessageProcessor* processor_ = nullptr;
   scoped_refptr<net::GrowableIOBuffer> buffer_;
   bool read_inflight_ = false;
 
   // Cancelled in the event that the connection is destroyed (along with
   // |this|) while a inflight callback is held by |processor_|.
   net::CancelableCompletionCallback process_msg_callback_;
 
   // Cancelled to guard against |this| being called back from a completed read
   // operation.
   net::CancelableCompletionCallback read_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpMessagePump);
 };
 
 }  // namespace blimp
 
 #endif  // BLIMP_NET_BLIMP_MESSAGE_PUMP_H_