blimp/net/browser_connection_handler.h - Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/browser_connection_handler.h

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002

Patch Set: Addressed haibin's feedback, made an ObserverList for ConnectionErrorObserver Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: blimp/net/browser_connection_handler.h

diff --git a/blimp/net/browser_connection_handler.h b/blimp/net/browser_connection_handler.h

index 74bb7f2bf8d1c5c1519ad089a60d8d2409e14a33..daf642d9e87436d3825d0afb338ed6d2c5cdba2f 100644

--- a/blimp/net/browser_connection_handler.h

+++ b/blimp/net/browser_connection_handler.h

@@ -49,8 +49,12 @@ class BLIMP_NET_EXPORT BrowserConnectionHandler

void OnConnectionError(int error) override;

private:

+ // Tears down the current connection and its affiliated objects without a

+ // corresponding ConnectionError.

void DropCurrentConnection();

+ ConnectionErrorObserver* error_observer_ = nullptr;

haibinlu 2016/01/04 19:45:45 still need error_observer_?

Kevin M 2016/01/04 20:42:13 Done.

// Routes incoming messages to the relevant feature-specific handlers.

scoped_ptr<BlimpMessageDemultiplexer> demultiplexer_;

« blimp/net/blimp_message_pump.cc ('K') | « blimp/net/blimp_message_pump.cc ('k') | blimp/net/browser_connection_handler.cc » ('j') | blimp/net/common.cc » ('J')