Implementation and fixes for Blimp client/engine E2E communication.

blimp/net/browser_connection_handler.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_
 #define BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "blimp/common/proto/blimp_message.pb.h"
@@ skipping 31 matching lines @@
       BlimpMessage::Type type,
       BlimpMessageProcessor* incoming_processor);
 
   // ConnectionHandler implementation.
   void HandleConnection(scoped_ptr<BlimpConnection> connection) override;
 
   // ConnectionErrorObserver implementation.
   void OnConnectionError(int error) override;
 
  private:
+  // Tears down the current connection and its affiliated objects without a
+  // corresponding ConnectionError.
   void DropCurrentConnection();
 
+  ConnectionErrorObserver* error_observer_ = nullptr;

[haibinlu, 2016/01/04 19:45:45]

still need  error_observer_?

[Kevin M, 2016/01/04 20:42:13]

Done.

+
   // Routes incoming messages to the relevant feature-specific handlers.
   scoped_ptr<BlimpMessageDemultiplexer> demultiplexer_;
 
   // Provides buffering of outgoing messages, for use in session-recovery.
   scoped_ptr<BlimpMessageOutputBuffer> output_buffer_;
 
   // Routes outgoing messages from feature-specific handlers to a single
   // message stream.
   scoped_ptr<BlimpMessageMultiplexer> multiplexer_;
 
   // Dispatches checkpoint/ACK messages to the outgoing processor, as the
   // incoming processor completes processing them.
   scoped_ptr<BlimpMessageCheckpointer> checkpointer_;
 
   // Holds network resources while there is a Client connected.
   scoped_ptr<BlimpConnection> connection_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserConnectionHandler);
 };
 
 }  // namespace blimp
 
 #endif  // BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_