Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2225)

Unified Diff: blimp/net/blimp_message_output_buffer.cc

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_message_output_buffer.cc
diff --git a/blimp/net/blimp_message_output_buffer.cc b/blimp/net/blimp_message_output_buffer.cc
index c599ffaff4f1f5ab6a7e1d04c9c102a41dadf9cc..7bf4fa31ca754c0bbbc08f53c5a918022e151ec9 100644
--- a/blimp/net/blimp_message_output_buffer.cc
+++ b/blimp/net/blimp_message_output_buffer.cc
@@ -20,6 +20,7 @@ BlimpMessageOutputBuffer::~BlimpMessageOutputBuffer() {}
void BlimpMessageOutputBuffer::SetOutputProcessor(
BlimpMessageProcessor* processor) {
+ DVLOG(1) << "SetOutputProcessor " << processor;
// Check that we are setting or removing the processor, not replacing it.
if (processor) {
DCHECK(!output_processor_);
@@ -36,6 +37,7 @@ void BlimpMessageOutputBuffer::SetOutputProcessor(
void BlimpMessageOutputBuffer::RetransmitBufferedMessages() {
DCHECK(output_processor_);
+ DVLOG(1) << "RetransmitBufferedMessages()";
// Prepend the entirety of |ack_buffer_| to |write_buffer_|.
write_buffer_.insert(write_buffer_.begin(),
@@ -57,8 +59,9 @@ int BlimpMessageOutputBuffer::GetUnacknowledgedMessageCountForTest() const {
void BlimpMessageOutputBuffer::ProcessMessage(
scoped_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
- VLOG(2) << "ProcessMessage (id=" << message->message_id()
- << ", type=" << message->type() << ")";
+ VLOG(2) << "OutputBuffer ProcessMessage (id=" << message->message_id()
haibinlu 2015/12/29 00:51:45 DVLOG instead?
Kevin M 2015/12/30 23:08:49 Done.
+ << ", type=" << message->type() << ", size=" << message->ByteSize()
+ << ")";
message->set_message_id(++prev_message_id_);
@@ -120,20 +123,21 @@ BlimpMessageOutputBuffer::BufferEntry::BufferEntry(
BlimpMessageOutputBuffer::BufferEntry::~BufferEntry() {}
void BlimpMessageOutputBuffer::WriteNextMessageIfReady() {
+ DVLOG(3) << "WriteNextMessageIfReady";
if (write_buffer_.empty()) {
- VLOG(2) << "Nothing to write.";
+ DVLOG(3) << "Nothing to write.";
return;
}
scoped_ptr<BlimpMessage> message_to_write(
new BlimpMessage(*write_buffer_.front()->message));
- VLOG(3) << "Writing message (id="
- << write_buffer_.front()->message->message_id()
- << ", type=" << message_to_write->type() << ")";
+ DVLOG(3) << "Writing message (id="
+ << write_buffer_.front()->message->message_id()
+ << ", type=" << message_to_write->type() << ")";
output_processor_->ProcessMessage(std::move(message_to_write),
write_complete_cb_.callback());
- VLOG(3) << "Queue size: " << write_buffer_.size();
+ DVLOG(3) << "Queue size: " << write_buffer_.size();
}
void BlimpMessageOutputBuffer::OnWriteComplete(int result) {

Powered by Google App Engine
This is Rietveld 408576698