Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4242)

Unified Diff: blimp/client/session/blimp_client_session.h

Issue 1551583003: Implementation and fixes for Blimp client/engine E2E communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@dtrainor-linux-cl1528243002
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/session/blimp_client_session.h
diff --git a/blimp/client/session/blimp_client_session.h b/blimp/client/session/blimp_client_session.h
index da8e74ab69452b710ee9a0c38eb6ff8aea85f6ef..6eb33691300f830ae8676aba3f1ee4e08aa8d72a 100644
--- a/blimp/client/session/blimp_client_session.h
+++ b/blimp/client/session/blimp_client_session.h
@@ -12,6 +12,7 @@
namespace blimp {
class BrowserConnectionHandler;
+class ClientConnectionManager;
class NavigationFeature;
class RenderWidgetFeature;
class TabControlFeature;
@@ -32,14 +33,22 @@ class BLIMP_CLIENT_EXPORT BlimpClientSession {
NavigationFeature* GetNavigationFeature() const;
RenderWidgetFeature* GetRenderWidgetFeature() const;
+ // Tells |connection_manager_| to start connecting to the remote host.
+ // Must be called on the IO thread.
+ void Connect();
+
protected:
virtual ~BlimpClientSession();
+ ClientConnectionManager* GetConnectionManager() const;
+
private:
// The BrowserConnectionHandler is here so that the BlimpClientSession can
// glue the feature-specific handlers to the actual network connection.
scoped_ptr<BrowserConnectionHandler> connection_handler_;
haibinlu 2015/12/29 00:51:45 can we have the similar BlimpNetworkComponent to c
Kevin M 2015/12/30 23:08:48 Done.
+ scoped_ptr<ClientConnectionManager> connection_manager_;
+
scoped_ptr<TabControlFeature> tab_control_feature_;
scoped_ptr<NavigationFeature> navigation_feature_;
scoped_ptr<RenderWidgetFeature> render_widget_feature_;

Powered by Google App Engine
This is Rietveld 408576698