Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: protoc_plugins/json_values_converter.py

Issue 1551553002: Remove DOM Distiller dependency on scoped_ptr<T>::Pass(). (Closed) Base URL: https://github.com/chromium/dom-distiller.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: protoc_plugins/json_values_converter.py
diff --git a/protoc_plugins/json_values_converter.py b/protoc_plugins/json_values_converter.py
index cbe4125aae539b4592d6d1aa296207b8df1a0961..fcc1488bc5e3534025f4ccd87ae65c5ef3ebe5a1 100755
--- a/protoc_plugins/json_values_converter.py
+++ b/protoc_plugins/json_values_converter.py
@@ -85,7 +85,7 @@ class CppConverterWriter(writer.CodeWriter):
' return false;\n'
'}}\n'
'\n'
- 'static scoped_ptr<base::Value> WriteToValue(const {generated_class_name}& message) {{\n'
+ 'static scoped_ptr<base::DictionaryValue> WriteToValue(const {generated_class_name}& message) {{\n'
' scoped_ptr<base::DictionaryValue> dict(new base::DictionaryValue());\n'
'',
generated_class_name=generated_class_name)
@@ -95,7 +95,7 @@ class CppConverterWriter(writer.CodeWriter):
self.FieldWriteToValue(field_proto)
self.Output(
- ' return dict.Pass();\n'
+ ' return dict;\n'
'',
generated_class_name=generated_class_name)
self.Output('}}')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698