chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc - Issue 1551503002: Convert Pass()→std::move() in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc ('k') | chrome/browser/safe_browsing/incident_reporting/state_store.cc » ('j') | chrome/browser/sessions/tab_restore_service_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc

index df11fa10676bd46c96eaabd5b478f4fda174ecb8..6d6c52bfdc86edfd1d5ed34598ff71c555c46370 100644

--- a/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc

@@ -2,12 +2,15 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h"

+#include <utility>

#include "base/bind.h"

#include "base/run_loop.h"

#include "chrome/browser/safe_browsing/incident_reporting/incident.h"

#include "chrome/browser/safe_browsing/incident_reporting/incident_receiver.h"

#include "chrome/browser/safe_browsing/incident_reporting/mock_incident_receiver.h"

-#include "chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h"

#include "chrome/common/safe_browsing/csd.pb.h"

#include "content/public/browser/resource_request_info.h"

#include "content/public/common/resource_type.h"

@@ -47,7 +50,7 @@ class FakeResourceRequestDetector : public ResourceRequestDetector {

public:

explicit FakeResourceRequestDetector(

scoped_ptr<IncidentReceiver> incident_receiver)

- : ResourceRequestDetector(incident_receiver.Pass()) {

+ : ResourceRequestDetector(std::move(incident_receiver)) {

FakeResourceRequestDetector::set_allow_null_profile_for_testing(true);

}

};

@@ -78,7 +81,7 @@ class ResourceRequestDetectorTest : public testing::Test {

false, // is_async

false); // is_using_lofi

- return url_request.Pass();

+ return url_request;

}

void ExpectNoIncident(const std::string& url,