chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc - Issue 1551503002: Convert Pass()→std::move() in //chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc

Issue 1551503002: Convert Pass()→std::move() in //chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc » ('j') | chrome/browser/sessions/tab_restore_service_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc b/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc

index 0e12a675b5de5a38cfb0e251e77e936ebe340e81..f9ea84c3407417006389cd67f17c9bbff931229d 100644

--- a/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h"

+#include <utility>

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/safe_browsing/incident_reporting/incident_receiver.h"

#include "chrome/browser/safe_browsing/incident_reporting/resource_request_incident.h"

@@ -251,7 +253,7 @@ namespace safe_browsing {

ResourceRequestDetector::ResourceRequestDetector(

scoped_ptr<IncidentReceiver> incident_receiver)

- : incident_receiver_(incident_receiver.Pass()),

+ : incident_receiver_(std::move(incident_receiver)),

allow_null_profile_for_testing_(false),

weak_ptr_factory_(this) {

InitializeHashSets();

@@ -379,7 +381,7 @@ void ResourceRequestDetector::ReportIncidentOnUIThread(

incident_receiver_->AddIncidentForProfile(

profile,

- make_scoped_ptr(new ResourceRequestIncident(incident_data.Pass())));

+ make_scoped_ptr(new ResourceRequestIncident(std::move(incident_data))));

}