Remove the code added to make extensions compile on Aura Android.

Remove the code added to make extensions compile on Aura Android.

BUG=NONE

Committed: https://crrev.com/12b8eae75903716455b44d2c25236e183cebbeb7
Cr-Commit-Position: refs/heads/master@{#372106}

[mfomitchev, 2016-01-04 22:09:43]

mfomitchev@chromium.org changed reviewers:
+ moshayedi@chromium.org, sievers@chromium.org

[Hadi, 2016-01-05 15:30:29]

There are also some changes from https://codereview.chromium.org/1419103010/
that we did for extensions to compile:

 * chrome/app/generated_resources.grd
 * chrome/browser/extensions/component_loader.cc
 * chrome/browser/ui/browser_navigator_params.{h,cc}

Should we rollback them too or keep them as they are?

[Hadi, 2016-01-05 15:40:54]

On 2016/01/05 15:30:29, Hadi wrote:
> There are also some changes from https://codereview.chromium.org/1419103010/
> that we did for extensions to compile:
> 
>  * chrome/app/generated_resources.grd
>  * chrome/browser/extensions/component_loader.cc
>  * chrome/browser/ui/browser_navigator_params.{h,cc}
> 
> Should we rollback them too or keep them as they are?

Just realized that you have made the changes for generated_resources &
browser_navigator_params in the other patch.

I am not sure about the significance of the change in component_loader.cc.

Other than that, lgtm.

[mfomitchev, 2016-01-05 15:56:31]

> I am not sure about the significance of the change in component_loader.cc.

Yeah, I figured we should leave that change, since the ifdef wasn't really doing
much good: we had enable_app_list set to false, but we still needed to include
chrome/grit/chromium_strings.h in order to be able to compile.

[mfomitchev, 2016-01-13 00:10:42]

@sievers: ping

[no sievers, 2016-01-14 20:20:40]

lgtm

[mfomitchev, 2016-01-15 01:01:04]

mfomitchev@chromium.org changed reviewers:
+ brettw@chromium.org

[mfomitchev, 2016-01-15 01:01:04]

brettw@chromium.org: PTAL

[brettw, 2016-01-19 23:55:16]

lgtm

[mfomitchev, 2016-01-20 00:12:25]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2016-01-20 00:12:30]

The CQ bit was unchecked by mfomitchev@chromium.org

[mfomitchev, 2016-01-20 01:48:20]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:49:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551423003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551423003/20001

[commit-bot: I haz the power, 2016-01-20 02:38:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 02:38:44]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[mfomitchev, 2016-01-26 22:14:00]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2016-01-26 22:14:00]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
moshayedi@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1551423003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-01-26 22:14:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551423003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551423003/40001

[commit-bot: I haz the power, 2016-01-26 23:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 23:21:27]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mfomitchev, 2016-01-27 21:16:35]

The CQ bit was checked by mfomitchev@chromium.org

[commit-bot: I haz the power, 2016-01-27 21:17:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551423003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551423003/40001

[commit-bot: I haz the power, 2016-01-27 22:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 22:14:40]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mfomitchev, 2016-01-28 15:59:21]

The CQ bit was checked by mfomitchev@chromium.org

[mfomitchev, 2016-01-28 15:59:22]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
moshayedi@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1551423003/#ps60001
(title: "Removing build/args/aura_android.gni from this CL - it has already been
deleted.")

[commit-bot: I haz the power, 2016-01-28 16:00:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1551423003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1551423003/60001

[commit-bot: I haz the power, 2016-01-28 16:46:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-28 16:47:24]

Description was changed from

==========
Remove the code added to make extensions compile on Aura Android.

BUG=NONE
==========

to

==========
Remove the code added to make extensions compile on Aura Android.

BUG=NONE

Committed: https://crrev.com/12b8eae75903716455b44d2c25236e183cebbeb7
Cr-Commit-Position: refs/heads/master@{#372106}
==========

[commit-bot: I haz the power, 2016-01-28 16:47:25]

Patchset 4 (id:??) landed as
https://crrev.com/12b8eae75903716455b44d2c25236e183cebbeb7
Cr-Commit-Position: refs/heads/master@{#372106}