Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: extensions/browser/api/serial/serial_api.cc

Issue 1551423003: Remove the code added to make extensions compile on Aura Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing build/args/aura_android.gni from this CL - it has already been deleted. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/serial/serial_api.h" 5 #include "extensions/browser/api/serial/serial_api.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/values.h" 10 #include "base/values.h"
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 } 79 }
80 80
81 bool SerialGetDevicesFunction::Prepare() { 81 bool SerialGetDevicesFunction::Prepare() {
82 set_work_thread_id(BrowserThread::FILE); 82 set_work_thread_id(BrowserThread::FILE);
83 return true; 83 return true;
84 } 84 }
85 85
86 void SerialGetDevicesFunction::Work() { 86 void SerialGetDevicesFunction::Work() {
87 DCHECK_CURRENTLY_ON(BrowserThread::FILE); 87 DCHECK_CURRENTLY_ON(BrowserThread::FILE);
88 88
89 // TODO(moshayedi): crbug.com/549257. Add USB support for Aura on Android.
90 #if !defined(OS_ANDROID)
91 scoped_ptr<device::SerialDeviceEnumerator> enumerator = 89 scoped_ptr<device::SerialDeviceEnumerator> enumerator =
92 device::SerialDeviceEnumerator::Create(); 90 device::SerialDeviceEnumerator::Create();
93 mojo::Array<device::serial::DeviceInfoPtr> devices = enumerator->GetDevices(); 91 mojo::Array<device::serial::DeviceInfoPtr> devices = enumerator->GetDevices();
94 results_ = serial::GetDevices::Results::Create( 92 results_ = serial::GetDevices::Results::Create(
95 devices.To<std::vector<linked_ptr<serial::DeviceInfo> > >()); 93 devices.To<std::vector<linked_ptr<serial::DeviceInfo> > >());
96 #endif
97 } 94 }
98 95
99 SerialConnectFunction::SerialConnectFunction() { 96 SerialConnectFunction::SerialConnectFunction() {
100 } 97 }
101 98
102 SerialConnectFunction::~SerialConnectFunction() { 99 SerialConnectFunction::~SerialConnectFunction() {
103 } 100 }
104 101
105 bool SerialConnectFunction::Prepare() { 102 bool SerialConnectFunction::Prepare() {
106 params_ = serial::Connect::Params::Create(*args_); 103 params_ = serial::Connect::Params::Create(*args_);
(...skipping 383 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 if (device->has_vendor_id) 487 if (device->has_vendor_id)
491 info->vendor_id.reset(new int(static_cast<int>(device->vendor_id))); 488 info->vendor_id.reset(new int(static_cast<int>(device->vendor_id)));
492 if (device->has_product_id) 489 if (device->has_product_id)
493 info->product_id.reset(new int(static_cast<int>(device->product_id))); 490 info->product_id.reset(new int(static_cast<int>(device->product_id)));
494 if (device->display_name) 491 if (device->display_name)
495 info->display_name.reset(new std::string(device->display_name)); 492 info->display_name.reset(new std::string(device->display_name));
496 return info; 493 return info;
497 } 494 }
498 495
499 } // namespace mojo 496 } // namespace mojo
OLDNEW
« no previous file with comments | « chrome/chrome_browser_extensions.gypi ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698