Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1551363002: [Interpreter] StateValuesRequireUpdate handles cases when deoptimization is disabled. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | test/mjsunit/mjsunit.status » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-graph-builder.cc
diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc
index 12d944407f10f2cca250fa306559f2eac0b0da74..2fa814638cf209c1ee75c37d1dbd9d8bb634feb7 100644
--- a/src/compiler/bytecode-graph-builder.cc
+++ b/src/compiler/bytecode-graph-builder.cc
@@ -26,8 +26,9 @@ class BytecodeGraphBuilder::FrameStateBeforeAndAfter {
}
~FrameStateBeforeAndAfter() {
- DCHECK(builder_->environment()->StateValuesAreUpToDate(
- accumulator_update_mode_));
+ DCHECK(!builder_->info()->is_deoptimization_enabled() ||
rmcilroy 2016/01/04 15:40:24 Could you move this up into StateValuesRequireUpda
mythria 2016/01/05 10:17:10 Done.
+ builder_->environment()->StateValuesAreUpToDate(
+ accumulator_update_mode_));
}
private:
« no previous file with comments | « no previous file | test/mjsunit/mjsunit.status » ('j') | test/mjsunit/mjsunit.status » ('J')

Powered by Google App Engine
This is Rietveld 408576698