Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1551253002:
ios: -Werror for third-party (Closed)
|
Created:
4 years, 11 months ago by Nico Modified:
4 years, 11 months ago Reviewers:
Mark Mentovai CC:
chromium-reviews, sdefresne Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionios: -Werror for third-party
BUG=573779
R=mark@chromium.org
Committed: https://crrev.com/cbd8cfb57078da8fd29b509d714d282d42b8a14c
Cr-Commit-Position: refs/heads/master@{#367402}
Patch Set 1 #Patch Set 2 : works, with nss roll and libwebp thing #Patch Set 3 : sqlite #
Total comments: 5
Patch Set 4 : simplify #Patch Set 5 : unsimplify #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== ios: -Werror for third-party BUG= ========== to ========== ios: -Werror for third-party needs: https://codereview.chromium.org/1558913002/ BUG= ==========
Description was changed from ========== ios: -Werror for third-party needs: https://codereview.chromium.org/1558913002/ BUG= ========== to ========== ios: -Werror for third-party needs: https://codereview.chromium.org/1558913002/ https://codereview.chromium.org/1558903002/ BUG= ==========
Description was changed from ========== ios: -Werror for third-party needs: https://codereview.chromium.org/1558913002/ https://codereview.chromium.org/1558903002/ BUG= ========== to ========== ios: -Werror for third-party needs: https://codereview.chromium.org/1558913002/ https://codereview.chromium.org/1558903002/ BUG=573779 ==========
Description was changed from ========== ios: -Werror for third-party needs: https://codereview.chromium.org/1558913002/ https://codereview.chromium.org/1558903002/ BUG=573779 ========== to ========== ios: -Werror for third-party needs: https://codereview.chromium.org/1558903002/ BUG=573779 ==========
Description was changed from ========== ios: -Werror for third-party needs: https://codereview.chromium.org/1558903002/ BUG=573779 ========== to ========== ios: -Werror for third-party BUG=573779 ==========
thakis@chromium.org changed reviewers: + mark@chromium.org
Last one for today. It might look like a gyp-only change, but I tried to do the corresponding gn changes. https://codereview.chromium.org/1551253002/diff/40001/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/1551253002/diff/40001/build/common.gypi#oldco... build/common.gypi:3225: 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', This hasn't made it into the gn port of the iOS build yet, so no gn version of thins change. https://codereview.chromium.org/1551253002/diff/40001/third_party/class-dump/... File third_party/class-dump/class-dump.gyp (right): https://codereview.chromium.org/1551253002/diff/40001/third_party/class-dump/... third_party/class-dump/class-dump.gyp:172: 'clang_warning_flags': [ This directory doesn't have a BUILD.gn file yet, so no gn version of this change. https://codereview.chromium.org/1551253002/diff/40001/third_party/sqlite/sqli... File third_party/sqlite/sqlite.gyp (right): https://codereview.chromium.org/1551253002/diff/40001/third_party/sqlite/sqli... third_party/sqlite/sqlite.gyp:250: ], This change already was present in the gn version, so no gn version of this change either.
LGTM https://codereview.chromium.org/1551253002/diff/40001/third_party/class-dump/... File third_party/class-dump/class-dump.gyp (right): https://codereview.chromium.org/1551253002/diff/40001/third_party/class-dump/... third_party/class-dump/class-dump.gyp:8: 'mac_sdk_min': '10.9', This should be unnecessary now.
https://codereview.chromium.org/1551253002/diff/40001/third_party/class-dump/... File third_party/class-dump/class-dump.gyp (right): https://codereview.chromium.org/1551253002/diff/40001/third_party/class-dump/... third_party/class-dump/class-dump.gyp:8: 'mac_sdk_min': '10.9', On 2016/01/04 20:16:28, Mark Mentovai wrote: > This should be unnecessary now. Done.
On 2016/01/04 20:19:14, Nico wrote: > https://codereview.chromium.org/1551253002/diff/40001/third_party/class-dump/... > File third_party/class-dump/class-dump.gyp (right): > > https://codereview.chromium.org/1551253002/diff/40001/third_party/class-dump/... > third_party/class-dump/class-dump.gyp:8: 'mac_sdk_min': '10.9', > On 2016/01/04 20:16:28, Mark Mentovai wrote: > > This should be unnecessary now. > > Done. …but on the wrong branch (－‸ლ) Done for real now. Thanks!
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org Link to the patchset: https://codereview.chromium.org/1551253002/#ps60001 (title: "simplify")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551253002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551253002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
Apparently the sdk_min stuff _is_ needed. Not sure why. On Mon, Jan 4, 2016 at 3:34 PM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote: > Try jobs failed on following builders: > ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, > > http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator... > ) > ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, > > http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni... > ) > > https://codereview.chromium.org/1551253002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org Link to the patchset: https://codereview.chromium.org/1551253002/#ps80001 (title: "unsimplify")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551253002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551253002/80001
Description was changed from ========== ios: -Werror for third-party BUG=573779 ========== to ========== ios: -Werror for third-party BUG=573779 R=mark@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) to pending queue manually as 44360fb8ab3af2e3a886fcd2ae21368a6185920a (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== ios: -Werror for third-party BUG=573779 R=mark@chromium.org ========== to ========== ios: -Werror for third-party BUG=573779 R=mark@chromium.org Committed: https://crrev.com/cbd8cfb57078da8fd29b509d714d282d42b8a14c Cr-Commit-Position: refs/heads/master@{#367402} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/cbd8cfb57078da8fd29b509d714d282d42b8a14c Cr-Commit-Position: refs/heads/master@{#367402} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
