Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/sqlite/sqlite.gyp

Issue 1551253002: ios: -Werror for third-party (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unsimplify Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/class-dump/class-dump.gyp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_sqlite%': 0, 7 'use_system_sqlite%': 0,
8 'required_sqlite_version': '3.6.1', 8 'required_sqlite_version': '3.6.1',
9 }, 9 },
10 'target_defaults': { 10 'target_defaults': {
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 '../icu/icu.gyp:icui18n', 236 '../icu/icu.gyp:icui18n',
237 '../icu/icu.gyp:icuuc', 237 '../icu/icu.gyp:icuuc',
238 ], 238 ],
239 'defines': [ 239 'defines': [
240 # Necessary to statically compile the extension. 240 # Necessary to statically compile the extension.
241 'SQLITE_CORE', 241 'SQLITE_CORE',
242 ], 242 ],
243 'sources': [ 243 'sources': [
244 'src/ext/icu/icu.c', 244 'src/ext/icu/icu.c',
245 ], 245 ],
246 'variables': {
247 'clang_warning_flags_unset': [
248 # icu.c uses assert(!"foo") instead of assert(false && "foo")
249 '-Wstring-conversion',
250 ],
251 },
246 }, 252 },
247 ], 253 ],
248 }], 254 }],
249 ['android_channel == "work"', { 255 ['android_channel == "work"', {
250 'target_defaults': { 256 'target_defaults': {
251 'defines': [ 257 'defines': [
252 'SQLITE_MAX_MMAP_SIZE=0', 258 'SQLITE_MAX_MMAP_SIZE=0',
253 ], 259 ],
254 }, 260 },
255 }, { # else: android_channel != "work" 261 }, { # else: android_channel != "work"
256 'target_defaults': { 262 'target_defaults': {
257 'defines': [ 263 'defines': [
258 # Allow 256MB mmap footprint per connection. Should not be too open-e nded 264 # Allow 256MB mmap footprint per connection. Should not be too open-e nded
259 # as that could cause memory fragmentation. 50MB encompasses the 99th 265 # as that could cause memory fragmentation. 50MB encompasses the 99th
260 # percentile of Chrome databases in the wild. 266 # percentile of Chrome databases in the wild.
261 # TODO(shess): A 64-bit-specific value could be 1G or more. 267 # TODO(shess): A 64-bit-specific value could be 1G or more.
262 # TODO(shess): Figure out if exceeding this is costly. 268 # TODO(shess): Figure out if exceeding this is costly.
263 'SQLITE_MAX_MMAP_SIZE=268435456', 269 'SQLITE_MAX_MMAP_SIZE=268435456',
264 ], 270 ],
265 }, 271 },
266 }], 272 }],
267 ], 273 ],
268 } 274 }
OLDNEW
« no previous file with comments | « third_party/class-dump/class-dump.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698