Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1551133002: Convert Pass()→std::move() in //ash (CrOS edition) (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
CC:
chromium-reviews, kalyank, oshima+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //ash (CrOS edition) (╯^□^)╯︵ ❄☃❄ BUG=557422 R=derat@chromium.org Committed: https://crrev.com/22724956ac1d6475f8178d6a68421ff164d87851 Cr-Commit-Position: refs/heads/master@{#367223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -42 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/key_hold_detector.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/accelerators/magnifier_key_scroller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/accelerators/spoken_feedback_toggler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/display/display_color_manager_chromeos.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/display/display_error_observer_chromeos.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/display/resolution_notification_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/bluetooth/bluetooth_notification_controller.cc View 4 chunks +8 lines, -3 lines 0 comments Download
M ash/system/chromeos/power/battery_notification.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_capture_tray_item.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/system/chromeos/screen_security/screen_share_tray_item.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/system/chromeos/session/logout_button_tray.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/system/chromeos/session/tray_session_length_limit.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.cc View 2 chunks +4 lines, -1 line 0 comments Download
M ash/system/chromeos/tray_display.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/virtual_keyboard_controller_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/cursor_manager_chromeos.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
dcheng
+avi for general review/sanity check +oshima for owners review
4 years, 11 months ago (2015-12-31 00:25:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551133002/1
4 years, 11 months ago (2015-12-31 00:26:10 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-31 01:16:20 UTC) #6
Daniel Erat
lgtm for ash owners and also for emoticon
4 years, 11 months ago (2015-12-31 02:10:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1551133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1551133002/1
4 years, 11 months ago (2015-12-31 03:13:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 03:18:02 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 03:18:52 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/22724956ac1d6475f8178d6a68421ff164d87851
Cr-Commit-Position: refs/heads/master@{#367223}

Powered by Google App Engine
This is Rietveld 408576698