Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: ash/accelerators/accelerator_controller_unittest.cc

Issue 1551133002: Convert Pass()→std::move() in //ash (CrOS edition) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ash/accelerators/accelerator_filter_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_controller.h" 5 #include "ash/accelerators/accelerator_controller.h"
6 6
7 #include "ash/accelerators/accelerator_table.h" 7 #include "ash/accelerators/accelerator_table.h"
8 #include "ash/accessibility_delegate.h" 8 #include "ash/accessibility_delegate.h"
9 #include "ash/ash_switches.h" 9 #include "ash/ash_switches.h"
10 #include "ash/display/display_manager.h" 10 #include "ash/display/display_manager.h"
(...skipping 850 matching lines...) Expand 10 before | Expand all | Expand 10 after
861 EXPECT_TRUE(ProcessInController(ui::Accelerator( 861 EXPECT_TRUE(ProcessInController(ui::Accelerator(
862 ui::VKEY_MEDIA_LAUNCH_APP1, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN))); 862 ui::VKEY_MEDIA_LAUNCH_APP1, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
863 EXPECT_EQ(2, delegate->handle_take_screenshot_count()); 863 EXPECT_EQ(2, delegate->handle_take_screenshot_count());
864 } 864 }
865 const ui::Accelerator volume_mute(ui::VKEY_VOLUME_MUTE, ui::EF_NONE); 865 const ui::Accelerator volume_mute(ui::VKEY_VOLUME_MUTE, ui::EF_NONE);
866 const ui::Accelerator volume_down(ui::VKEY_VOLUME_DOWN, ui::EF_NONE); 866 const ui::Accelerator volume_down(ui::VKEY_VOLUME_DOWN, ui::EF_NONE);
867 const ui::Accelerator volume_up(ui::VKEY_VOLUME_UP, ui::EF_NONE); 867 const ui::Accelerator volume_up(ui::VKEY_VOLUME_UP, ui::EF_NONE);
868 { 868 {
869 TestVolumeControlDelegate* delegate = new TestVolumeControlDelegate; 869 TestVolumeControlDelegate* delegate = new TestVolumeControlDelegate;
870 ash::Shell::GetInstance()->system_tray_delegate()->SetVolumeControlDelegate( 870 ash::Shell::GetInstance()->system_tray_delegate()->SetVolumeControlDelegate(
871 scoped_ptr<VolumeControlDelegate>(delegate).Pass()); 871 scoped_ptr<VolumeControlDelegate>(delegate));
872 EXPECT_EQ(0, delegate->handle_volume_mute_count()); 872 EXPECT_EQ(0, delegate->handle_volume_mute_count());
873 EXPECT_TRUE(ProcessInController(volume_mute)); 873 EXPECT_TRUE(ProcessInController(volume_mute));
874 EXPECT_EQ(1, delegate->handle_volume_mute_count()); 874 EXPECT_EQ(1, delegate->handle_volume_mute_count());
875 EXPECT_EQ(volume_mute, delegate->last_accelerator()); 875 EXPECT_EQ(volume_mute, delegate->last_accelerator());
876 EXPECT_EQ(0, delegate->handle_volume_down_count()); 876 EXPECT_EQ(0, delegate->handle_volume_down_count());
877 EXPECT_TRUE(ProcessInController(volume_down)); 877 EXPECT_TRUE(ProcessInController(volume_down));
878 EXPECT_EQ(1, delegate->handle_volume_down_count()); 878 EXPECT_EQ(1, delegate->handle_volume_down_count());
879 EXPECT_EQ(volume_down, delegate->last_accelerator()); 879 EXPECT_EQ(volume_down, delegate->last_accelerator());
880 EXPECT_EQ(0, delegate->handle_volume_up_count()); 880 EXPECT_EQ(0, delegate->handle_volume_up_count());
881 EXPECT_TRUE(ProcessInController(volume_up)); 881 EXPECT_TRUE(ProcessInController(volume_up));
882 EXPECT_EQ(1, delegate->handle_volume_up_count()); 882 EXPECT_EQ(1, delegate->handle_volume_up_count());
883 EXPECT_EQ(volume_up, delegate->last_accelerator()); 883 EXPECT_EQ(volume_up, delegate->last_accelerator());
884 } 884 }
885 // Brightness 885 // Brightness
886 // ui::VKEY_BRIGHTNESS_DOWN/UP are not defined on Windows. 886 // ui::VKEY_BRIGHTNESS_DOWN/UP are not defined on Windows.
887 const ui::Accelerator brightness_down(ui::VKEY_BRIGHTNESS_DOWN, ui::EF_NONE); 887 const ui::Accelerator brightness_down(ui::VKEY_BRIGHTNESS_DOWN, ui::EF_NONE);
888 const ui::Accelerator brightness_up(ui::VKEY_BRIGHTNESS_UP, ui::EF_NONE); 888 const ui::Accelerator brightness_up(ui::VKEY_BRIGHTNESS_UP, ui::EF_NONE);
889 { 889 {
890 DummyBrightnessControlDelegate* delegate = 890 DummyBrightnessControlDelegate* delegate =
891 new DummyBrightnessControlDelegate; 891 new DummyBrightnessControlDelegate;
892 GetController()->SetBrightnessControlDelegate( 892 GetController()->SetBrightnessControlDelegate(
893 scoped_ptr<BrightnessControlDelegate>(delegate).Pass()); 893 scoped_ptr<BrightnessControlDelegate>(delegate));
894 EXPECT_EQ(0, delegate->handle_brightness_down_count()); 894 EXPECT_EQ(0, delegate->handle_brightness_down_count());
895 EXPECT_TRUE(ProcessInController(brightness_down)); 895 EXPECT_TRUE(ProcessInController(brightness_down));
896 EXPECT_EQ(1, delegate->handle_brightness_down_count()); 896 EXPECT_EQ(1, delegate->handle_brightness_down_count());
897 EXPECT_EQ(brightness_down, delegate->last_accelerator()); 897 EXPECT_EQ(brightness_down, delegate->last_accelerator());
898 EXPECT_EQ(0, delegate->handle_brightness_up_count()); 898 EXPECT_EQ(0, delegate->handle_brightness_up_count());
899 EXPECT_TRUE(ProcessInController(brightness_up)); 899 EXPECT_TRUE(ProcessInController(brightness_up));
900 EXPECT_EQ(1, delegate->handle_brightness_up_count()); 900 EXPECT_EQ(1, delegate->handle_brightness_up_count());
901 EXPECT_EQ(brightness_up, delegate->last_accelerator()); 901 EXPECT_EQ(brightness_up, delegate->last_accelerator());
902 } 902 }
903 903
904 // Keyboard brightness 904 // Keyboard brightness
905 const ui::Accelerator alt_brightness_down(ui::VKEY_BRIGHTNESS_DOWN, 905 const ui::Accelerator alt_brightness_down(ui::VKEY_BRIGHTNESS_DOWN,
906 ui::EF_ALT_DOWN); 906 ui::EF_ALT_DOWN);
907 const ui::Accelerator alt_brightness_up(ui::VKEY_BRIGHTNESS_UP, 907 const ui::Accelerator alt_brightness_up(ui::VKEY_BRIGHTNESS_UP,
908 ui::EF_ALT_DOWN); 908 ui::EF_ALT_DOWN);
909 { 909 {
910 EXPECT_TRUE(ProcessInController(alt_brightness_down)); 910 EXPECT_TRUE(ProcessInController(alt_brightness_down));
911 EXPECT_TRUE(ProcessInController(alt_brightness_up)); 911 EXPECT_TRUE(ProcessInController(alt_brightness_up));
912 DummyKeyboardBrightnessControlDelegate* delegate = 912 DummyKeyboardBrightnessControlDelegate* delegate =
913 new DummyKeyboardBrightnessControlDelegate; 913 new DummyKeyboardBrightnessControlDelegate;
914 GetController()->SetKeyboardBrightnessControlDelegate( 914 GetController()->SetKeyboardBrightnessControlDelegate(
915 scoped_ptr<KeyboardBrightnessControlDelegate>(delegate).Pass()); 915 scoped_ptr<KeyboardBrightnessControlDelegate>(delegate));
916 EXPECT_EQ(0, delegate->handle_keyboard_brightness_down_count()); 916 EXPECT_EQ(0, delegate->handle_keyboard_brightness_down_count());
917 EXPECT_TRUE(ProcessInController(alt_brightness_down)); 917 EXPECT_TRUE(ProcessInController(alt_brightness_down));
918 EXPECT_EQ(1, delegate->handle_keyboard_brightness_down_count()); 918 EXPECT_EQ(1, delegate->handle_keyboard_brightness_down_count());
919 EXPECT_EQ(alt_brightness_down, delegate->last_accelerator()); 919 EXPECT_EQ(alt_brightness_down, delegate->last_accelerator());
920 EXPECT_EQ(0, delegate->handle_keyboard_brightness_up_count()); 920 EXPECT_EQ(0, delegate->handle_keyboard_brightness_up_count());
921 EXPECT_TRUE(ProcessInController(alt_brightness_up)); 921 EXPECT_TRUE(ProcessInController(alt_brightness_up));
922 EXPECT_EQ(1, delegate->handle_keyboard_brightness_up_count()); 922 EXPECT_EQ(1, delegate->handle_keyboard_brightness_up_count());
923 EXPECT_EQ(alt_brightness_up, delegate->last_accelerator()); 923 EXPECT_EQ(alt_brightness_up, delegate->last_accelerator());
924 } 924 }
925 #endif 925 #endif
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
1139 #if defined(OS_CHROMEOS) 1139 #if defined(OS_CHROMEOS)
1140 // Test IME shortcuts again with unnormalized accelerators (Chrome OS only). 1140 // Test IME shortcuts again with unnormalized accelerators (Chrome OS only).
1141 { 1141 {
1142 const ui::Accelerator shift_alt_press(ui::VKEY_MENU, ui::EF_SHIFT_DOWN); 1142 const ui::Accelerator shift_alt_press(ui::VKEY_MENU, ui::EF_SHIFT_DOWN);
1143 const ReleaseAccelerator shift_alt(ui::VKEY_MENU, ui::EF_SHIFT_DOWN); 1143 const ReleaseAccelerator shift_alt(ui::VKEY_MENU, ui::EF_SHIFT_DOWN);
1144 const ui::Accelerator alt_shift_press(ui::VKEY_SHIFT, ui::EF_ALT_DOWN); 1144 const ui::Accelerator alt_shift_press(ui::VKEY_SHIFT, ui::EF_ALT_DOWN);
1145 const ReleaseAccelerator alt_shift(ui::VKEY_SHIFT, ui::EF_ALT_DOWN); 1145 const ReleaseAccelerator alt_shift(ui::VKEY_SHIFT, ui::EF_ALT_DOWN);
1146 1146
1147 DummyImeControlDelegate* delegate = new DummyImeControlDelegate; 1147 DummyImeControlDelegate* delegate = new DummyImeControlDelegate;
1148 GetController()->SetImeControlDelegate( 1148 GetController()->SetImeControlDelegate(
1149 scoped_ptr<ImeControlDelegate>(delegate).Pass()); 1149 scoped_ptr<ImeControlDelegate>(delegate));
1150 EXPECT_EQ(0, delegate->handle_next_ime_count()); 1150 EXPECT_EQ(0, delegate->handle_next_ime_count());
1151 EXPECT_FALSE(ProcessInController(shift_alt_press)); 1151 EXPECT_FALSE(ProcessInController(shift_alt_press));
1152 EXPECT_TRUE(ProcessInController(shift_alt)); 1152 EXPECT_TRUE(ProcessInController(shift_alt));
1153 EXPECT_EQ(1, delegate->handle_next_ime_count()); 1153 EXPECT_EQ(1, delegate->handle_next_ime_count());
1154 EXPECT_FALSE(ProcessInController(alt_shift_press)); 1154 EXPECT_FALSE(ProcessInController(alt_shift_press));
1155 EXPECT_TRUE(ProcessInController(alt_shift)); 1155 EXPECT_TRUE(ProcessInController(alt_shift));
1156 EXPECT_EQ(2, delegate->handle_next_ime_count()); 1156 EXPECT_EQ(2, delegate->handle_next_ime_count());
1157 1157
1158 // We should NOT switch IME when e.g. Shift+Alt+X is pressed and X is 1158 // We should NOT switch IME when e.g. Shift+Alt+X is pressed and X is
1159 // released. 1159 // released.
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
1401 ui::VKEY_MEDIA_LAUNCH_APP1, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN))); 1401 ui::VKEY_MEDIA_LAUNCH_APP1, ui::EF_SHIFT_DOWN | ui::EF_CONTROL_DOWN)));
1402 EXPECT_EQ(2, delegate->handle_take_screenshot_count()); 1402 EXPECT_EQ(2, delegate->handle_take_screenshot_count());
1403 } 1403 }
1404 // Brightness 1404 // Brightness
1405 const ui::Accelerator brightness_down(ui::VKEY_BRIGHTNESS_DOWN, ui::EF_NONE); 1405 const ui::Accelerator brightness_down(ui::VKEY_BRIGHTNESS_DOWN, ui::EF_NONE);
1406 const ui::Accelerator brightness_up(ui::VKEY_BRIGHTNESS_UP, ui::EF_NONE); 1406 const ui::Accelerator brightness_up(ui::VKEY_BRIGHTNESS_UP, ui::EF_NONE);
1407 { 1407 {
1408 DummyBrightnessControlDelegate* delegate = 1408 DummyBrightnessControlDelegate* delegate =
1409 new DummyBrightnessControlDelegate; 1409 new DummyBrightnessControlDelegate;
1410 GetController()->SetBrightnessControlDelegate( 1410 GetController()->SetBrightnessControlDelegate(
1411 scoped_ptr<BrightnessControlDelegate>(delegate).Pass()); 1411 scoped_ptr<BrightnessControlDelegate>(delegate));
1412 EXPECT_EQ(0, delegate->handle_brightness_down_count()); 1412 EXPECT_EQ(0, delegate->handle_brightness_down_count());
1413 EXPECT_TRUE(ProcessInController(brightness_down)); 1413 EXPECT_TRUE(ProcessInController(brightness_down));
1414 EXPECT_EQ(1, delegate->handle_brightness_down_count()); 1414 EXPECT_EQ(1, delegate->handle_brightness_down_count());
1415 EXPECT_EQ(brightness_down, delegate->last_accelerator()); 1415 EXPECT_EQ(brightness_down, delegate->last_accelerator());
1416 EXPECT_EQ(0, delegate->handle_brightness_up_count()); 1416 EXPECT_EQ(0, delegate->handle_brightness_up_count());
1417 EXPECT_TRUE(ProcessInController(brightness_up)); 1417 EXPECT_TRUE(ProcessInController(brightness_up));
1418 EXPECT_EQ(1, delegate->handle_brightness_up_count()); 1418 EXPECT_EQ(1, delegate->handle_brightness_up_count());
1419 EXPECT_EQ(brightness_up, delegate->last_accelerator()); 1419 EXPECT_EQ(brightness_up, delegate->last_accelerator());
1420 } 1420 }
1421 // Volume 1421 // Volume
1422 const ui::Accelerator volume_mute(ui::VKEY_VOLUME_MUTE, ui::EF_NONE); 1422 const ui::Accelerator volume_mute(ui::VKEY_VOLUME_MUTE, ui::EF_NONE);
1423 const ui::Accelerator volume_down(ui::VKEY_VOLUME_DOWN, ui::EF_NONE); 1423 const ui::Accelerator volume_down(ui::VKEY_VOLUME_DOWN, ui::EF_NONE);
1424 const ui::Accelerator volume_up(ui::VKEY_VOLUME_UP, ui::EF_NONE); 1424 const ui::Accelerator volume_up(ui::VKEY_VOLUME_UP, ui::EF_NONE);
1425 { 1425 {
1426 EXPECT_TRUE(ProcessInController(volume_mute)); 1426 EXPECT_TRUE(ProcessInController(volume_mute));
1427 EXPECT_TRUE(ProcessInController(volume_down)); 1427 EXPECT_TRUE(ProcessInController(volume_down));
1428 EXPECT_TRUE(ProcessInController(volume_up)); 1428 EXPECT_TRUE(ProcessInController(volume_up));
1429 TestVolumeControlDelegate* delegate = new TestVolumeControlDelegate; 1429 TestVolumeControlDelegate* delegate = new TestVolumeControlDelegate;
1430 ash::Shell::GetInstance()->system_tray_delegate()->SetVolumeControlDelegate( 1430 ash::Shell::GetInstance()->system_tray_delegate()->SetVolumeControlDelegate(
1431 scoped_ptr<VolumeControlDelegate>(delegate).Pass()); 1431 scoped_ptr<VolumeControlDelegate>(delegate));
1432 EXPECT_EQ(0, delegate->handle_volume_mute_count()); 1432 EXPECT_EQ(0, delegate->handle_volume_mute_count());
1433 EXPECT_TRUE(ProcessInController(volume_mute)); 1433 EXPECT_TRUE(ProcessInController(volume_mute));
1434 EXPECT_EQ(1, delegate->handle_volume_mute_count()); 1434 EXPECT_EQ(1, delegate->handle_volume_mute_count());
1435 EXPECT_EQ(volume_mute, delegate->last_accelerator()); 1435 EXPECT_EQ(volume_mute, delegate->last_accelerator());
1436 EXPECT_EQ(0, delegate->handle_volume_down_count()); 1436 EXPECT_EQ(0, delegate->handle_volume_down_count());
1437 EXPECT_TRUE(ProcessInController(volume_down)); 1437 EXPECT_TRUE(ProcessInController(volume_down));
1438 EXPECT_EQ(1, delegate->handle_volume_down_count()); 1438 EXPECT_EQ(1, delegate->handle_volume_down_count());
1439 EXPECT_EQ(volume_down, delegate->last_accelerator()); 1439 EXPECT_EQ(volume_down, delegate->last_accelerator());
1440 EXPECT_EQ(0, delegate->handle_volume_up_count()); 1440 EXPECT_EQ(0, delegate->handle_volume_up_count());
1441 EXPECT_TRUE(ProcessInController(volume_up)); 1441 EXPECT_TRUE(ProcessInController(volume_up));
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
1488 public: 1488 public:
1489 DeprecatedAcceleratorTester() {} 1489 DeprecatedAcceleratorTester() {}
1490 ~DeprecatedAcceleratorTester() override {} 1490 ~DeprecatedAcceleratorTester() override {}
1491 1491
1492 void SetUp() override { 1492 void SetUp() override {
1493 AcceleratorControllerTest::SetUp(); 1493 AcceleratorControllerTest::SetUp();
1494 1494
1495 // For testing the deprecated and new IME shortcuts. 1495 // For testing the deprecated and new IME shortcuts.
1496 DummyImeControlDelegate* delegate = new DummyImeControlDelegate; 1496 DummyImeControlDelegate* delegate = new DummyImeControlDelegate;
1497 GetController()->SetImeControlDelegate( 1497 GetController()->SetImeControlDelegate(
1498 scoped_ptr<ImeControlDelegate>(delegate).Pass()); 1498 scoped_ptr<ImeControlDelegate>(delegate));
1499 } 1499 }
1500 1500
1501 ui::Accelerator CreateAccelerator(const AcceleratorData& data) const { 1501 ui::Accelerator CreateAccelerator(const AcceleratorData& data) const {
1502 ui::Accelerator result(data.keycode, data.modifiers); 1502 ui::Accelerator result(data.keycode, data.modifiers);
1503 result.set_type(data.trigger_on_press ? ui::ET_KEY_PRESSED 1503 result.set_type(data.trigger_on_press ? ui::ET_KEY_PRESSED
1504 : ui::ET_KEY_RELEASED); 1504 : ui::ET_KEY_RELEASED);
1505 return result; 1505 return result;
1506 } 1506 }
1507 1507
1508 void ResetStateIfNeeded() { 1508 void ResetStateIfNeeded() {
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
1578 EXPECT_TRUE(IsMessageCenterEmpty()); 1578 EXPECT_TRUE(IsMessageCenterEmpty());
1579 1579
1580 // If the action is LOCK_SCREEN, we must reset the state by unlocking the 1580 // If the action is LOCK_SCREEN, we must reset the state by unlocking the
1581 // screen before we proceed testing the rest of accelerators. 1581 // screen before we proceed testing the rest of accelerators.
1582 ResetStateIfNeeded(); 1582 ResetStateIfNeeded();
1583 } 1583 }
1584 } 1584 }
1585 #endif // defined(OS_CHROMEOS) 1585 #endif // defined(OS_CHROMEOS)
1586 1586
1587 } // namespace ash 1587 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ash/accelerators/accelerator_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698