Breakdown "unhooked" memory regions by VMA pathnames and permissions.

Breakdown "unhooked" memory regions by VMA pathnames and permissions.

BUG=244163
R=bulach@chromium.org, glider@chromium.org, peria@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202575

[bulach, 2013-05-22 15:12:18]

https://codereview.chromium.org/15511005/diff/13001/tools/deep_memory_profile...
File tools/deep_memory_profiler/policy.android.browser.json (right):

https://codereview.chromium.org/15511005/diff/13001/tools/deep_memory_profile...
tools/deep_memory_profiler/policy.android.browser.json:19: "unhooked-data-data",
small suggestion: rather than all this data-*, I think we could have the
following, wdyt?

    {
      "name": "unhooked-file-exec-lib-chrome",
      "mappedfile": "^/.*?(chromeview|content).*",
      "mappedexecutable": "x",
      "allocator": "unhooked"
    },
    {
      "name": "unhooked-file-exec",
      "mappedfile": "^/.*",
      "mappedexecutable": "x",
      "allocator": "unhooked"
    },
    {
      "name": "unhooked-file-nonexec-lib-chrome",
      "mappedfile": "^/.*?(chromeview|content).*",
      "allocator": "unhooked"
    },
    {
      "name": "unhooked-file-nonexec",
      "mappedfile": "^/.*",
      "allocator": "unhooked"
    },

[pliard, 2013-05-22 15:24:06]

On 2013/05/22 15:12:18, bulach wrote:
>
https://codereview.chromium.org/15511005/diff/13001/tools/deep_memory_profile...
> File tools/deep_memory_profiler/policy.android.browser.json (right):
> 
>
https://codereview.chromium.org/15511005/diff/13001/tools/deep_memory_profile...
> tools/deep_memory_profiler/policy.android.browser.json:19:
"unhooked-data-data",
> small suggestion: rather than all this data-*, I think we could have the
> following, wdyt?
> 
>     {
>       "name": "unhooked-file-exec-lib-chrome",
>       "mappedfile": "^/.*?(chromeview|content).*",
>       "mappedexecutable": "x",
>       "allocator": "unhooked"
>     },
>     {
>       "name": "unhooked-file-exec",
>       "mappedfile": "^/.*",
>       "mappedexecutable": "x",
>       "allocator": "unhooked"
>     },
>     {
>       "name": "unhooked-file-nonexec-lib-chrome",
>       "mappedfile": "^/.*?(chromeview|content).*",
>       "allocator": "unhooked"
>     },
>     {
>       "name": "unhooked-file-nonexec",
>       "mappedfile": "^/.*",
>       "allocator": "unhooked"
>     },

SGTM!

[Dai Mikurube (NOT FULLTIME), 2013-05-22 15:25:40]

Sounds good!  Imported these patterns.

[bulach, 2013-05-23 14:28:46]

another suggestion :)

diff --git a/tools/deep_memory_profiler/policy.android.browser.json
b/tools/deep_memory_profiler/policy
index 1b25c04..558e8d1 100644
--- a/tools/deep_memory_profiler/policy.android.browser.json
+++ b/tools/deep_memory_profiler/policy.android.browser.json
@@ -14,6 +14,7 @@
     "unhooked-ashmem-dalvik-other",
     "unhooked-pvrsrvkm",
     "unhooked-system-dex",
+    "unhooked-chrome-dex",
     "unhooked-other-ashmem",
     "unhooked-anonymous",
     "unhooked-file-exec",
@@ -129,6 +130,11 @@
       "allocator": "unhooked"
     },
     {
+      "name": "unhooked-chrome-dex",
+      "mappedfile": "^/.*?(chrome|content).*?apk@classes.dex",
+      "allocator": "unhooked"
+    },
+    {
       "name": "unhooked-other-ashmem",
       "mappedfile": "/dev/ashmem/.*",
       "allocator": "unhooked"

[Dai Mikurube (NOT FULLTIME), 2013-05-27 05:50:41]

Imported the pattern.  Thanks!

[Dai Mikurube (NOT FULLTIME), 2013-05-27 08:32:01]

I believe it's ready for review.

bulach, peria:
Could you take a look at dmprof.py when you have time?
(bulach: some JSON label names are changed from previous patches.)

glider:
Could you take a look at deep-heap-profile.cc?  (It just removes some output.)

[Alexander Potapenko, 2013-05-27 08:46:34]

deep-heap-profile LGTM

[peria, 2013-05-27 08:54:02]

lgtm

[bulach, 2013-05-28 08:31:58]

lgtm, thanks dai!

https://codereview.chromium.org/15511005/diff/31001/tools/deep_memory_profile...
File tools/deep_memory_profiler/policy.android.browser.json (right):

https://codereview.chromium.org/15511005/diff/31001/tools/deep_memory_profile...
tools/deep_memory_profiler/policy.android.browser.json:162: "allocator":
"unhooked"
nit: it'd be great if you could add these to android.renderer too!
I guess all of them would be interesting, but specially
unhooked-file-nonexec-lib-chrome and unhooked-file-exec-lib-chrome..

[Dai Mikurube (NOT FULLTIME), 2013-05-28 12:09:23]

Thanks!  Updated the patch.  Committing...

[Dai Mikurube (NOT FULLTIME), 2013-05-28 15:50:02]

Committed patchset #11 manually as r202575 (presubmit successful).