tools/deep_memory_profiler/tests/dmprof_test.py - Issue 15511005: Breakdown "unhooked" memory regions by VMA pathnames and permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/deep_memory_profiler/tests/dmprof_test.py

Issue 15511005: Breakdown "unhooked" memory regions by VMA pathnames and permissions. (Closed) Base URL: git@github.com:dmikurube/chromium.git@work

Patch Set: addressed bulach's comment Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/deep_memory_profiler/tests/dmprof_test.py

diff --git a/tools/deep_memory_profiler/tests/dmprof_test.py b/tools/deep_memory_profiler/tests/dmprof_test.py

index 794927fe6e2b7b173e2270dc9585e466771fc29b..c146b0a58da1583a2aa1ce8ef327c0043ce93b05 100755

--- a/tools/deep_memory_profiler/tests/dmprof_test.py

+++ b/tools/deep_memory_profiler/tests/dmprof_test.py

@@ -176,11 +176,11 @@ class PolicyTest(unittest.TestCase):

symbol_mapping_cache.add(FUNCTION_SYMBOLS, 0x1212, 'v8::create')

symbol_mapping_cache.add(FUNCTION_SYMBOLS, 0x1381, 'WebKit::create')

- bucket1 = dmprof.Bucket([0x1212, 0x013], False, 0x29492, '_Z')

+ bucket1 = dmprof.Bucket([0x1212, 0x013], 'malloc', 0x29492, '_Z')

bucket1.symbolize(symbol_mapping_cache)

- bucket2 = dmprof.Bucket([0x18242, 0x1381], False, 0x9492, '_Z')

+ bucket2 = dmprof.Bucket([0x18242, 0x1381], 'malloc', 0x9492, '_Z')

bucket2.symbolize(symbol_mapping_cache)

- bucket3 = dmprof.Bucket([0x18242, 0x181], False, 0x949, '_Z')

+ bucket3 = dmprof.Bucket([0x18242, 0x181], 'malloc', 0x949, '_Z')

bucket3.symbolize(symbol_mapping_cache)

self.assertEqual('malloc-v8', policy.find(bucket1))

« no previous file with comments | « tools/deep_memory_profiler/policy.t0.json ('k') | no next file » | no next file with comments »